Implement support for tests using real libvirt with FOG_LIBVIRT_URI - #197
Merged
Conversation
ekohl
reviewed
Jul 29, 2026
ekohl
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks really good. Only some minor inline comments but I'd be happy to merge this as is already.
Contributor
Author
|
Just pushed with all fixes applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
rake livefails with:First commit from this PR fixes that so
rake liveworks.2nd commit implements support for running tests against real libvirt by using
FOG_LIBVIRT_URIenv var.All these are fully supported and work correctly:
(something like
FOG_LIBVIRT_URI=qemu+ssh://host/system rakeshould also work but I haven't tested)I also fixed tests so they cleanup afterwards so there won't be test leftovers when running against real libvirt.
But note that with this feature tests shouldn't do something like
servers.all.each(&:destroy)to not cause someone a bad day when run with real libvirt. If needed then such should only be run when using libvirt test driver only.