Skip to content

Explicitly set model='virtio-scsi' for SCSI controllers on Q35 guests #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
B-Woody wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Explicitly set model='virtio-scsi' for SCSI controllers on Q35 guests #193

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe16dc6
Fix: Explicitly set model='virtio-scsi' for SCSI controllers on Q35 g…
B-Woody Jul 10, 2026
19eb4f1
Remove trailing whitespace
ekohl Jul 10, 2026
b6d3db7
Trying to fix conditional statement that failed in test
B-Woody Jul 10, 2026
b12d352
trigger ci again
B-Woody Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/fog/libvirt/models/compute/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,11 @@
end
end

if volumes.any? { |v| v.respond_to?(:bus) && v.bus == 'scsi' } ||

Check warning on line 399 in lib/fog/libvirt/models/compute/server.rb

View workflow job for this annotation

GitHub Actions / runner / rubocop 

[rubocop] reported by reviewdog 🐶
Trailing whitespace detected.

Raw Output:
lib/fog/libvirt/models/compute/server.rb:399:82: C: Layout/TrailingWhitespace: Trailing whitespace detected.
(respond_to?(:disks) && disks.any? { |d| d.is_a?(Hash) && d[:bus] == 'scsi' })

Check warning on line 400 in lib/fog/libvirt/models/compute/server.rb

View workflow job for this annotation

GitHub Actions / runner / rubocop 

[rubocop] reported by reviewdog 🐶
Align the operands of a condition in an `if` statement spanning multiple lines.

Raw Output:
lib/fog/libvirt/models/compute/server.rb:400:21: C: Layout/MultilineOperationIndentation: Align the operands of a condition in an `if` statement spanning multiple lines.
xml.controller(:type => 'scsi', :index => '0', :model => 'virtio-scsi')
end

nics.each do |nic|
xml.interface(:type => nic.type) do
xml.mac(:address => nic.mac) if nic.mac
Expand Down
Loading