Add timezone database copy for go run image #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the size of the images will grow for 355Kb
treeder
reviewed
Mar 28, 2018
| @@ -65,6 +65,8 @@ func (h *GoLangHelper) DockerfileBuildCmds() []string { | |||
|
|
|||
| func (h *GoLangHelper) DockerfileCopyCmds() []string { | |||
| return []string{ | |||
| "COPY --from=build-stage /usr/local/go/lib/time/zoneinfo.zip " + | |||
There was a problem hiding this comment.
So, i'm not sure, but faced with this while was developing a function with go
There was a problem hiding this comment.
we should just have it in base image we build from? string of issues over this, made some suggestions fnproject/dockers#13 - we probably need to add for all langs (like certs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #211