Skip to content

feat(api): expose effective queue in task action metadata - #8245

Merged
ursucarina merged 2 commits into
mainfrom
carina/action-queue-metadata
Oct 27, 2026
Merged

ursucarina merged 2 commits into
mainfrom
carina/action-queue-metadata

Conversation

@ursucarina

@ursucarina ursucarina commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Task actions can override the run's default queue, but the public action read model does not expose their queue. Clients cannot reliably display an action's effective target queue from the run default alone.

What changes were proposed in this pull request?

Add optional TaskActionMetadata.queue (field 4), exposed as metadata.task.queue in action details and list/watch JSON responses. Its contract is the effective task queue, including the recorded run default when no action override was set; it is absent when the effective queue is unknown. Queue metadata is scoped to task actions through the existing metadata oneof. Regenerate Go, Python, Rust, and TypeScript bindings.

This branch starts from the Flyte main commit currently pinned by the downstream consumer, keeping the dependency change limited to this additive field.

How was this patch tested?

  • Buf lint for the changed schema.
  • Buf breaking check against the branch base.
  • go test ./gen/go/flyteidl2/workflow (generated package compilation).
  • Regenerated language bindings with the repository's pinned Buf plugin versions; repeated generation is byte-identical.
  • Verified JSON round-trip through the task metadata oneof and descriptor placement: optional queue field 4 on TaskActionMetadata, with no queue field on ActionMetadata.
  • git diff --check.

Check all the applicable boxes

  • I updated the documentation accordingly (field contract).
  • All relevant checks passed.
  • All commits are signed-off.

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina added the added Merged changes that add new functionality label Oct 26, 2026
@ursucarina
ursucarina marked this pull request as ready for review October 26, 2026 21:09
Comment thread flyteidl2/workflow/run_definition.proto Outdated
// Effective target queue for this task action, including the run default when
// no action-level queue override was specified. Unset when the queue is unknown
// or the action type does not use a task queue.
optional string queue = 19;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need it. It is already in TaskAction Metadata and that is the one to use.

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina changed the title feat(api): expose effective task queue in action metadata feat(api): expose effective queue in task action metadata Oct 27, 2026
@ursucarina
ursucarina enabled auto-merge (squash) October 27, 2026 00:26
@ursucarina
ursucarina merged commit b6e77fb into main Oct 27, 2026
24 checks passed
@ursucarina
ursucarina deleted the carina/action-queue-metadata branch October 27, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added Merged changes that add new functionality flyte2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants