Repository navigation
Conversation
5de3b72 to
40b8176
Compare
|
can you please run |
|
@ursucarina this would require a UI change too... Unless we plan to pin the old(incorrect) JSON name as well? |
|
The PR still only contains
|
|
also @popojk are we okay with retiring the field like this? Or should we deprecate it instead? |
|
Thanks @AdilFayyaz for the detailed review! You're right - the PR only contains I've attempted to regenerate the Python bindings locally using Could you let me know if there's a way to trigger a regeneration, or would you prefer I close this PR and open a new one with the correct setup? Happy to do whatever works best for the project. |
2bba6d6 to
92ed285
Compare
…ithub.com> I, Jah-yee <166608075+Jah-yee@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e670d1c Signed-off-by: Jah-yee <166608075+Jah-yee@users.noreply.github.com>
d87b0b4 to
855944a
Compare
Tracking issue
Related to #7558
Why are the changes needed?
The ActionMetadata protobuf field is misspelled as
funtion_name, which produces the incorrect generated API name and breaks the intendedFunctionNamereferences.What changes were proposed in this pull request?
function_namewhile retaining wire number 13.FuntionNametoFunctionName.Generated bindings are intentionally not committed because the local environment does not have
buf; please run the repository regeneration workflow (/regen) after review.How was this patch tested?
make bufwas attempted locally but could not run becausebufis not installed. All commits are signed-off.