Skip to content

fix: correct ActionMetadata function name typo - #8087

Open
Jah-yee wants to merge 1 commit into
flyteorg:mainfrom
Jah-yee:fix/actionmetadata-function-name
Open

Jah-yee wants to merge 1 commit into
flyteorg:mainfrom
Jah-yee:fix/actionmetadata-function-name

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Sep 28, 2026

Copy link
Copy Markdown

Tracking issue

Related to #7558

Why are the changes needed?

The ActionMetadata protobuf field is misspelled as funtion_name, which produces the incorrect generated API name and breaks the intended FunctionName references.

What changes were proposed in this pull request?

  • Rename the proto field to function_name while retaining wire number 13.
  • Update the two Flyte backend references from FuntionName to FunctionName.

Generated bindings are intentionally not committed because the local environment does not have buf; please run the repository regeneration workflow (/regen) after review.

How was this patch tested?

make buf was attempted locally but could not run because buf is not installed. All commits are signed-off.

@Jah-yee
Jah-yee force-pushed the fix/actionmetadata-function-name branch from 5de3b72 to 40b8176 Compare September 29, 2026 08:38
@AdilFayyaz

Copy link
Copy Markdown
Contributor

can you please run make gen and commit the gen/go, python, ts and rust in this PR.

@AdilFayyaz AdilFayyaz added the changed For changes in existing functionality label Sep 29, 2026
@AdilFayyaz

Copy link
Copy Markdown
Contributor

@ursucarina this would require a UI change too... Unless we plan to pin the old(incorrect) JSON name as well?

@AdilFayyaz

Copy link
Copy Markdown
Contributor

The PR still only contains gen/go/ changes. CI also expects these files to be regenerated and committed:

  • gen/python/flyteidl2/workflow/run_definition_pb2.py
  • gen/python/flyteidl2/workflow/run_definition_pb2.pyi
  • gen/ts/flyteidl2/workflow/run_definition_pb.ts
  • gen/rust/src/flyteidl2.workflow.rs

@AdilFayyaz

Copy link
Copy Markdown
Contributor

also @popojk are we okay with retiring the field like this? Or should we deprecate it instead?

@Jah-yee

Jah-yee commented Oct 1, 2026

Copy link
Copy Markdown
Author

Thanks @AdilFayyaz for the detailed review! You're right - the PR only contains gen/go/ changes. I was using buf locally but Docker isn't available in my environment, so I couldn't run the full make buf to regenerate gen/python/, gen/ts/, and gen/rust/ files.

I've attempted to regenerate the Python bindings locally using buf generate for the specific proto file, and it appears the Python files in upstream main are already consistent with the function_name field. However, I understand the CI check-generate job runs the full make buf and compares against committed files.

Could you let me know if there's a way to trigger a regeneration, or would you prefer I close this PR and open a new one with the correct setup? Happy to do whatever works best for the project.

@Jah-yee
Jah-yee force-pushed the fix/actionmetadata-function-name branch from 2bba6d6 to 92ed285 Compare October 21, 2026 13:38
…ithub.com>

I, Jah-yee <166608075+Jah-yee@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e670d1c

Signed-off-by: Jah-yee <166608075+Jah-yee@users.noreply.github.com>
@Jah-yee
Jah-yee force-pushed the fix/actionmetadata-function-name branch from d87b0b4 to 855944a Compare October 22, 2026 17:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changed For changes in existing functionality flyte2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants