refactor: initial feature_comments #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexache
suggested changes
Oct 31, 2023
| @Column(name = "id") | ||
| private Long id; | ||
|
|
||
| @Column(nullable = false) |
There was a problem hiding this comment.
(Опционально) для таких полей с датами есть удобная функция у hibernate с аудит полями - даты будут автоматически проставляться при нужных аннотациях
| return commentMapper.mapToCommentDto(comments); | ||
| } | ||
|
|
||
| @Transactional |
There was a problem hiding this comment.
Эта аннотация не может работать на приватных методах в силу того, как она функционирует
| return commentMapper.mapToCommentDto(comments); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Где-то есть @transactional, где-то нет
| "key": "rootEvent", | ||
| "value": "" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Мне кажется, или я не нашел тест кейса на попытку редактирования/удаления чужого комментария?
…-with-me into feature_comments
alexache
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.