-
-
Notifications
You must be signed in to change notification settings - Fork 411
Add Typst integration (and appease clippy) #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
I would appreciate feedback, especially from @flxzt, both about the looks/idea and the code |
|
I am unsure whether to increment the save version number, would need some info from the maintainers. |
background transparent by default
|
I think this is enough for a first version. The auto-save and option between pixel and vector are not must-haves, and about incrementing the version number, I would need feedback from maintainers (most of the save format seems to be from @flxzt) |
|
Not a maintainer, but looks pretty promising! I have a couple of comments / suggestions though (not in order of importance or anything): (also saw you just commit something as I'm writing this, I hope my comments aren't already out-of-date)
As for the UI
Finally, I'm still not too familiar with GTK and more complicated Rnote internals as a whole, so I can't comment on much more.. |
Thanks for the feedback, you are right, I did seem to make a few oversights. I will look into all of them, but I can already say that tinymist integration is close to impossible, at least for me. That is something that would require IDE-like infrastructure, which a simple GTK text field most likely does not have. |
|
There does seem to be a library GtkSourceView for gtk4 that helps with code completion, but still probably a herculean task to set up and integrate with something like tinymist. |
|
Yeah, that is something that is definitely too much for a first version, maybe at a later point in time. This is also not meant to be a Typst IDE, just a way to write something scientific like with LaTeX. |
|
Lilaq is now working |
|
I have now fixed all the feedback except for the misalignment of the middle line (which is draggable, and honestly not that bad), and the tinymist stuff since that is way too hard |
|
@flxzt I fixed all the clippy messages, if that was what is keeping you from merging this. Would be nice if you could merge this, since I have other changes conflicting with this I want to work on |
|
Typst support is something that is super exciting, this is quite incredible! I need to do a proper review on this huge diff. It looks good, but it might take a little while until I am able to do it |
Also, remove random vertical seperater from shape page
Vim habits caused me so much pain before this lol Also, I switched the position of the insert button
|
Btw if this ever gets merged, I also have another branch based on this where I also added a marker tool |
|
One trick that could be used for the IDE part is the use of temporary files. I've seen it done on some GUI sftp software. Show the folder content, and if you want to edit a text file on remote, you can "open with" your favorite IDE and it just opens the file with the IDE. Internally, it downloads and copy the file to a temp folder, calls the "open with" command on the file (so you can choose any program that opens txt), and more importantly watches the files so that when you save it in the IDE, it syncs the change back to the remote. Using the same tactic here, we could make it possible to edit each typst element in vscode with all the benefits of the IDE support |
|
I also noticed I need to set the flag for the flatpak somewhere so that it is allowed to access the internet for typst plugins |




Fixes #644
Current state (as of first commit): button with a menu that has a preview button and renders into a vector
Ideal end state: button with a menu that automatically updates its preview, rendering into an image or vector format that contains its original text for editing, but can also cancel in cases where some resources went missing and can't be recovered