Skip to content

Conversation

@Xyndra
Copy link

@Xyndra Xyndra commented Nov 14, 2025

Fixes #644

Current state (as of first commit): button with a menu that has a preview button and renders into a vector
Ideal end state: button with a menu that automatically updates its preview, rendering into an image or vector format that contains its original text for editing, but can also cancel in cases where some resources went missing and can't be recovered

@Xyndra
Copy link
Author

Xyndra commented Nov 14, 2025

  • Live preview
  • Higher resolution in the preview
  • Fix monospace
  • Option between image and vector format (considered unimportant/useless for first version)
  • Allow for changing text after inserting (with proper cancel button)
  • Possibly some kind of auto-saving for changes since there are a lot of important changes happening without closing the menu and the menu can simply be closed with escape atm
  • Consider shipping fonts for typst

@Xyndra
Copy link
Author

Xyndra commented Nov 14, 2025

how it looks atm:

image

@Xyndra
Copy link
Author

Xyndra commented Nov 15, 2025

I would appreciate feedback, especially from @flxzt, both about the looks/idea and the code

@Xyndra
Copy link
Author

Xyndra commented Nov 15, 2025

I am unsure whether to increment the save version number, would need some info from the maintainers.
It does not crash in either direction, but accessing it with an older version removes the Typst text metadata.

@Xyndra Xyndra marked this pull request as ready for review November 16, 2025 11:51
@Xyndra
Copy link
Author

Xyndra commented Nov 16, 2025

I think this is enough for a first version. The auto-save and option between pixel and vector are not must-haves, and about incrementing the version number, I would need feedback from maintainers (most of the save format seems to be from @flxzt)

@anesthetice
Copy link
Contributor

Not a maintainer, but looks pretty promising! I have a couple of comments / suggestions though (not in order of importance or anything):

(also saw you just commit something as I'm writing this, I hope my comments aren't already out-of-date)

  • Any reason for using version 0.12.0 of typst when 0.14.0 is out?
  • I would move the typst-related code in crates/rnote-engine/src/utils.rs to their own file
  • Is there a way to import typst packages (e.g. CeTZ)?
  • I realize I am way too dependent on code-completion (e.g. from tinymist) to write typst, but somewhat hard to use without to be frank.

As for the UI

satty_2025-11-16_13:15:01

Finally, I'm still not too familiar with GTK and more complicated Rnote internals as a whole, so I can't comment on much more..

@Xyndra
Copy link
Author

Xyndra commented Nov 16, 2025

Not a maintainer, but looks pretty promising! I have a couple of comments / suggestions though (not in order of importance or anything):

(also saw you just commit something as I'm writing this, I hope my comments aren't already out-of-date)

* Any reason for using version `0.12.0` of typst when `0.14.0` is out?

* I would move the typst-related code in [crates/rnote-engine/src/utils.rs](https://github.com/flxzt/rnote/pull/1587/files#diff-69e14b6632502e3ecc34bc99cab25aebed4717bb0b288df3f5f8fb96808827a4) to their own file

* Is there a way to import typst packages (e.g. CeTZ)?

* I realize I am way too dependent on code-completion (e.g. from tinymist) to write typst, but somewhat hard to use without to be frank.

As for the UI
satty_2025-11-16_13:15:01

Finally, I'm still not too familiar with GTK and more complicated Rnote internals as a whole, so I can't comment on much more..

Thanks for the feedback, you are right, I did seem to make a few oversights. I will look into all of them, but I can already say that tinymist integration is close to impossible, at least for me. That is something that would require IDE-like infrastructure, which a simple GTK text field most likely does not have.

@anesthetice
Copy link
Contributor

There does seem to be a library GtkSourceView for gtk4 that helps with code completion, but still probably a herculean task to set up and integrate with something like tinymist.

@Xyndra
Copy link
Author

Xyndra commented Nov 16, 2025

Yeah, that is something that is definitely too much for a first version, maybe at a later point in time. This is also not meant to be a Typst IDE, just a way to write something scientific like with LaTeX.

@Xyndra
Copy link
Author

Xyndra commented Nov 16, 2025

Lilaq is now working
image

@Xyndra
Copy link
Author

Xyndra commented Nov 16, 2025

I have now fixed all the feedback except for the misalignment of the middle line (which is draggable, and honestly not that bad), and the tinymist stuff since that is way too hard

@Xyndra
Copy link
Author

Xyndra commented Nov 17, 2025

@flxzt I fixed all the clippy messages, if that was what is keeping you from merging this. Would be nice if you could merge this, since I have other changes conflicting with this I want to work on

@Xyndra Xyndra changed the title Add Typst integration Add Typst integration (and appease clippy) Nov 17, 2025
@flxzt
Copy link
Owner

flxzt commented Nov 17, 2025

Typst support is something that is super exciting, this is quite incredible!

I need to do a proper review on this huge diff. It looks good, but it might take a little while until I am able to do it

Also, remove random vertical seperater from shape page
Vim habits caused me so much pain before this lol Also, I switched the
position of the insert button
@Xyndra
Copy link
Author

Xyndra commented Nov 18, 2025

Btw if this ever gets merged, I also have another branch based on this where I also added a marker tool

@Doublonmousse
Copy link
Collaborator

One trick that could be used for the IDE part is the use of temporary files.

I've seen it done on some GUI sftp software. Show the folder content, and if you want to edit a text file on remote, you can "open with" your favorite IDE and it just opens the file with the IDE. Internally, it downloads and copy the file to a temp folder, calls the "open with" command on the file (so you can choose any program that opens txt), and more importantly watches the files so that when you save it in the IDE, it syncs the change back to the remote.

Using the same tactic here, we could make it possible to edit each typst element in vscode with all the benefits of the IDE support

@Xyndra
Copy link
Author

Xyndra commented Nov 20, 2025

I also noticed I need to set the flag for the flatpak somewhere so that it is allowed to access the internet for typst plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add typst support to typewriter

4 participants