-
-
Notifications
You must be signed in to change notification settings - Fork 412
re: New higher-performance rnote file format, and atomic file saving #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anesthetice
wants to merge
18
commits into
flxzt:main
Choose a base branch
from
anesthetice:re-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, lots left to do
…mplement cli and legacy loading, as well as clean things up
…ole (not finished though)
…nor changes to `set_compression`, added documentation for v1
…ements to save (less unwraps)
Contributor
Author
|
@flxzt, @Doublonmousse, I'd say this PR is ready for review. Take all the time you need of course, and feel free to ask me for information, changes, etc. 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal of this PR is to improve the handling of
.rnotesave files.tl;dr
* improvement factor measured only with respect to
EngineSnapshot <-> bytesMain changes:
zstdinstead ofgzipHere's a diagram of the simplified process to get from
EngineSnapshotto a.rnotesave file and vice-versa.fixes #1128
Note that this PR is a re-write of #1177, some of the important changes being:
(+)parallelism for serialization and compression(+)the introduction of a file version separate from the version of Rnote(-)scrapped save preferences (not worth complexity cost)(-)scrapped alternative serialization methods (for compatibility reasons)