fix(framework): Bound task log uploader shutdown - #7918
Draft
tanertopal wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 18, 2026
tanertopal
force-pushed
the
agent/shutdown-heartbeat-worker
branch
from
August 18, 2026 16:11
8ee262d to
3f6694f
Compare
tanertopal
force-pushed
the
agent/shutdown-log-uploader
branch
from
August 18, 2026 16:11
5c6335a to
24159d9
Compare
tanertopal
force-pushed
the
agent/shutdown-heartbeat-worker
branch
from
August 18, 2026 16:25
3f6694f to
4aebc33
Compare
tanertopal
force-pushed
the
agent/shutdown-log-uploader
branch
from
August 18, 2026 16:25
24159d9 to
ea6a5f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Log upload must not consume the full process shutdown window. Because log appends are non-idempotent, a timed-out batch cannot safely be retried when the server may already have accepted it.
Stack
Umbrella/reference: #7895 — Prevent task executor shutdown deadlock
Merge the stack in order. After the previous PR merges, retarget this PR to
main.Validation
pytest py/flwr/common/logger_test.pygit diff --check