Skip to content

fix(framework): Bound task log uploader shutdown - #7918

Draft
tanertopal wants to merge 1 commit into
agent/shutdown-heartbeat-workerfrom
agent/shutdown-log-uploader
Draft

fix(framework): Bound task log uploader shutdown#7918
tanertopal wants to merge 1 commit into
agent/shutdown-heartbeat-workerfrom
agent/shutdown-log-uploader

Conversation

@tanertopal

@tanertopal tanertopal commented Aug 18, 2026

Copy link
Copy Markdown
Member

What changed

  • bound task log-upload RPCs with the task-worker deadline
  • retain definitively unavailable batches while stopping
  • discard deadline-expired batches whose delivery is ambiguous
  • keep the stop sentinel from dropping a retained final batch

Why

Log upload must not consume the full process shutdown window. Because log appends are non-idempotent, a timed-out batch cannot safely be retried when the server may already have accepted it.

Stack

Umbrella/reference: #7895 — Prevent task executor shutdown deadlock

Merge the stack in order. After the previous PR merges, retarget this PR to main.

Validation

  • pytest py/flwr/common/logger_test.py
  • Ruff and Black on the changed logger modules
  • git diff --check

@github-actions github-actions Bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Aug 18, 2026
@tanertopal
tanertopal force-pushed the agent/shutdown-heartbeat-worker branch from 8ee262d to 3f6694f Compare August 18, 2026 16:11
@tanertopal
tanertopal force-pushed the agent/shutdown-log-uploader branch from 5c6335a to 24159d9 Compare August 18, 2026 16:11
@tanertopal
tanertopal force-pushed the agent/shutdown-heartbeat-worker branch from 3f6694f to 4aebc33 Compare August 18, 2026 16:25
@tanertopal
tanertopal force-pushed the agent/shutdown-log-uploader branch from 24159d9 to ea6a5f4 Compare August 18, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant