fix(framework): Make retry waits cancellable - #7915
Draft
tanertopal wants to merge 2 commits into
Draft
Conversation
This was referenced Aug 18, 2026
tanertopal
force-pushed
the
agent/shutdown-exit-foundation
branch
from
August 18, 2026 16:11
f6e59e5 to
1aa34cf
Compare
tanertopal
force-pushed
the
agent/shutdown-retry-cancellation
branch
from
August 18, 2026 16:11
324924d to
4b67ca0
Compare
tanertopal
force-pushed
the
agent/shutdown-exit-foundation
branch
from
August 18, 2026 16:24
1aa34cf to
959c61a
Compare
tanertopal
force-pushed
the
agent/shutdown-retry-cancellation
branch
from
August 18, 2026 16:25
4b67ca0 to
218f3ee
Compare
tanertopal
force-pushed
the
agent/shutdown-exit-foundation
branch
2 times, most recently
from
August 21, 2026 11:03
31b4f44 to
1f4725a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RetryInvoker.disable_retries()APIWhy
Lowering
max_triesdoes not wake an invocation that is already sleeping in backoff. Shutdown needs an explicit operation that prevents new retries and interrupts current waits.Stack
Umbrella/reference: #7895 — Prevent task executor shutdown deadlock
Merge the stack in order. After the previous PR merges, retarget this PR to
main.Validation
pytest py/flwr/supercore/retry/retry_invoker_test.pygit diff --check