Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated object metrics #997

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

hasithsen
Copy link
Contributor

@hasithsen hasithsen commented Dec 8, 2024

Suspend and readiness metrics recording removed from Receiver reconciler.

Refer fluxcd/flux2#5083.

@darkowlzz darkowlzz changed the title feat: Remove deprecated object metrics from controllers fluxcd/flux2#5083 Remove deprecated object metrics Dec 11, 2024
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

Before:

# HELP gotk_reconcile_condition The current condition status of a GitOps Toolkit resource reconciliation.
# TYPE gotk_reconcile_condition gauge
gotk_reconcile_condition{kind="Receiver",name="test-receiver",namespace="default",status="False",type="Ready"} 0
gotk_reconcile_condition{kind="Receiver",name="test-receiver",namespace="default",status="True",type="Ready"} 1
gotk_reconcile_condition{kind="Receiver",name="test-receiver",namespace="default",status="Unknown",type="Ready"} 0
# HELP gotk_reconcile_duration_seconds The duration in seconds of a GitOps Toolkit resource reconciliation.
# TYPE gotk_reconcile_duration_seconds histogram
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.01"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.038363583488692544"} 3
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.1471764538093883"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.5646216173286169"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="2.166090855590701"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="8.309900738254731"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="31.879757075478317"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="122.30217221643493"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="469.19495946736544"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="1799.9999999999986"} 4
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="+Inf"} 4
gotk_reconcile_duration_seconds_sum{kind="Receiver",name="test-receiver",namespace="default"} 0.119644221
gotk_reconcile_duration_seconds_count{kind="Receiver",name="test-receiver",namespace="default"} 4
# HELP gotk_suspend_status The current suspend status of a GitOps Toolkit resource.
# TYPE gotk_suspend_status gauge
gotk_suspend_status{kind="Receiver",name="test-receiver",namespace="default"} 0

After:

# HELP gotk_reconcile_duration_seconds The duration in seconds of a GitOps Toolkit resource reconciliation.
# TYPE gotk_reconcile_duration_seconds histogram
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.01"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.038363583488692544"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.1471764538093883"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="0.5646216173286169"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="2.166090855590701"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="8.309900738254731"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="31.879757075478317"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="122.30217221643493"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="469.19495946736544"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="1799.9999999999986"} 1
gotk_reconcile_duration_seconds_bucket{kind="Receiver",name="test-receiver",namespace="default",le="+Inf"} 1
gotk_reconcile_duration_seconds_sum{kind="Receiver",name="test-receiver",namespace="default"} 0.00629886
gotk_reconcile_duration_seconds_count{kind="Receiver",name="test-receiver",namespace="default"} 1

LGTM!

@stefanprodan
Copy link
Member

@hasithsen please squash

@stefanprodan stefanprodan merged commit 0667ba6 into fluxcd:main Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants