Skip to content

Make GitHub username comparisons case-insensitive. #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make GitHub username comparisons case-insensitive. #293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
051821e
GitHub usernames are case-insensitive but case preserving. This fixes…
TonyLovesDevOps Sep 24, 2024
c332235
Fix username comparison logic.
TonyLovesDevOps Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion github/client_repositories_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"errors"
"fmt"
"strings"

"github.com/fluxcd/go-git-providers/gitprovider"
)
Expand Down Expand Up @@ -108,7 +109,8 @@ func (c *UserRepositoriesClient) Create(ctx context.Context,
return nil, fmt.Errorf("unable to get owner from API")
}

if ref.GetIdentity() != idRef.GetIdentity() {
// GitHub usernames are case insensitive, so compare them with https://pkg.go.dev/strings#EqualFold
if !strings.EqualFold(ref.GetIdentity(), idRef.GetIdentity()) {
return nil, gitprovider.NewErrIncorrectUser(ref.GetIdentity())
}

Expand Down