testsuite: set exec.service="sdexec" where necessary - #30
Merged
Merged
Conversation
Problem: sdexec-constrain-resources requires that exec.service is set to "sdexec", but some tests in t0002-prolog-housekeeping.t do not conform to this requirement. Update the test configs to set the required exec.service="sdexec".
grondo
added
the
merge-when-passing
Contributor
Merge Queue Status
This pull request spent 14 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flux-framework/flux-core#7802 enhances validation of the
[exec]config table to ensure that ifexec.sdexec-constrain-resourcesis set,exec.service = "sdexec"is also set. This breaks a few tests in flux-pam which don't follow that requirement.Fix the tests.