export FLUX_JOB_RANKS to housekeeping scripts
#6728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Problem: FLUX_JOB_RANKS is exported to prolog and epilog scripts but not housekeeping. Add FLUX_JOB_RANKS to the housekeeping script environment. Fixes flux-framework#6703
Problem: The documentation of the job script environment in flux-environment(7) documents that `FLUX_JOB_RANKS` is only available in the prolog and epilog, but it is now exported to housekeeping scripts as well. Update the docs to note that `FLUX_JOB_RANKS` is available in all three script environments: prolog, epilog, and housekeeping.
Problem: The housekeeping tests do not check that FLUX_JOB_RANKS is set correctly in the script environment. Add a test to the existing housekeeping environment checks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6728 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 534 534
Lines 89279 89288 +9
=======================================
+ Hits 74828 74840 +12
+ Misses 14451 14448 -3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #6703 by exporting
FLUX_JOB_RANKSto housekeeping scripts. Not much more to it than that.