fix(telescope-install): drop bin/fsa hard-dependency; spawn via dart run fluttersdk_telescope#8
Merged
Conversation
…run fluttersdk_telescope Mirrors the Cat C subprocess pattern landed in fluttersdk_dusk (dusk_install_command.dart#3) and surfaces during the E2E smoke for the dusk-cli-fixes-rename plan. Before this change, telescope:install spawned './bin/fsa plugin:install fluttersdk_telescope' as a subprocess (HARDCODED to fastcli). On a clean checkout where bin/fsa has not been AOT-compiled yet, telescope:install crashed with 'ProcessException: No such file or directory'. The same class of bug as Bug 1 from the dusk-cli-fixes-rename plan (substrate mcp:install assumed bin/fsa unconditionally). Fix: route the plugin:install subprocess through 'dart run fluttersdk_telescope' which proxies the artisan substrate via the telescope CLI wrapper (preloads TelescopeArtisanProvider, sets delegateToConsumer: false). Surface unchanged for consumers who already have fsa scaffolded. - lib/src/commands/telescope_install_command.dart:75-78,97-100 — subprocess args flipped from './bin/fsa' + ['plugin:install', ...] to 'dart' + ['run', 'fluttersdk_telescope', 'plugin:install', ...]. Docblock at lines 5-30 updated to reflect the new behavior; legacy claim about 'bin/artisan.dart wrapper rejection' removed (no longer applies once we route through the telescope-own CLI wrapper instead of fluttersdk_artisan). - test/src/commands/telescope_install_command_test.dart:97-115,123-147 — 3 test assertions updated to match the new subprocess args. - CHANGELOG: ### Changed bullet under [Unreleased]. Discovered during the dusk-cli-fixes-rename plan's E2E verification phase. The dusk plan's plan.md notes this in Cross-Project Observations.
There was a problem hiding this comment.
Pull request overview
This PR updates telescope:install so it no longer assumes the consumer already has an AOT-compiled bin/fsa available, by routing the scaffold + plugin registration subprocesses through dart run fluttersdk_telescope ... instead.
Changes:
- Switch subprocess invocations from
dart run fluttersdk_artisan install/./bin/fsa plugin:install ...todart run fluttersdk_telescope ...for both steps. - Update
TelescopeInstallCommandtests to assert the new subprocess executable/args and ordering. - Add a
[Unreleased]changelog entry describing the behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/commands/telescope_install_command.dart | Routes both scaffold and plugin:install steps through dart run fluttersdk_telescope to remove the hard dependency on ./bin/fsa. |
| test/src/commands/telescope_install_command_test.dart | Updates assertions and test text to match the new subprocess calls. |
| CHANGELOG.md | Documents the install-chain change under [Unreleased]. |
- dart format test/src/commands/telescope_install_command_test.dart for CI's format gate (Dart version drift between local and CI). - CHANGELOG: clarify the behavior delta. Original wording 'Surface unchanged for consumers who already have fsa scaffolded' was inaccurate — fsa is now bypassed unconditionally even when present, adding a small startup-time delta on the single telescope:install invocation. Matches dusk's unconditional dart-run pattern for cross-plugin consistency. Addresses Copilot review on CHANGELOG.md:13.
…ll-fastcli-fallback # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telescope:installno longer depends on the AOT-compiledbin/fsa. The chained subprocess calls (install+plugin:install fluttersdk_telescope) now spawndart run fluttersdk_telescope ...directly through the telescope CLI wrapper, mirroring the Cat C subprocess pattern landed influttersdk_dusk(dusk_install_command.dartStep 3.3 of the cross-repo plandusk-cli-fixes-rename).Bug
Before this change,
telescope:installspawned./bin/fsa plugin:install fluttersdk_telescopeHARDCODED. On a clean checkout wherebin/fsahas not been AOT-compiled yet, the command crashed:Same class of bug as Bug 1 from
dusk-cli-fixes-rename(substratemcp:installassumedbin/fsaunconditionally), discovered during that plan's E2E verification phase on a freshflutter createconsumer.Fix
Route both chained subprocesses through
dart run fluttersdk_telescopewhich proxies the artisan substrate via the telescope CLI wrapper (bin/fluttersdk_telescope.dart— preloadsTelescopeArtisanProvider, setsdelegateToConsumer: false). The wrapper itself is Flutter-free so the chain works on a clean checkout where fsa has not been compiled.lib/src/commands/telescope_install_command.dart:75-78:['run', 'fluttersdk_artisan', 'install']→['run', 'fluttersdk_telescope', 'install'].lib/src/commands/telescope_install_command.dart:97-100:'./bin/fsa'+['plugin:install', 'fluttersdk_telescope']→'dart'+['run', 'fluttersdk_telescope', 'plugin:install', 'fluttersdk_telescope'].bin/artisan.dartwrapper rejection is removed — that constraint no longer applies once we route through the telescope-own CLI wrapper instead offluttersdk_artisan.test/src/commands/telescope_install_command_test.dart: 3 test assertions updated to match the new subprocess args (test names + expectedrunner.callsshapes).CHANGELOG.md:### Changedbullet under[Unreleased].Surface unchanged for consumers who already have fsa scaffolded: the chained subprocess routes through the dart toolchain either way;
./bin/fsais just a faster proxy when present.Test plan
Plus E2E smoke against this branch:
Pre-fix, the chain crashed at the second subprocess with
ProcessException: No such file or directorybecause./bin/fsadid not exist yet.Companion PR cluster
This is a follow-up to the cross-repo
dusk-cli-fixes-renamePR cluster:--invocationflagdart run fluttersdk_duskrename dusk#10 — dusk-side Bug 1 + Bug 3 + rename sweep (where this same pattern fix landed for dusk's chained subprocesses in dusk_install_command.dart:123,151-155)telescope:installfastcli-absent fallbackIndependent of #7; cuts cleanly from master so review and revert are isolated.
🤖 Generated with Claude Code