Skip to content

release: 0.0.4 (artisan ^0.0.8) + magic_devtools install repoint#16

Merged
anilcancakir merged 2 commits into
masterfrom
release/0.0.4
Jun 17, 2026
Merged

release: 0.0.4 (artisan ^0.0.8) + magic_devtools install repoint#16
anilcancakir merged 2 commits into
masterfrom
release/0.0.4

Conversation

@anilcancakir

Copy link
Copy Markdown
Contributor

What

  • Bumps version 0.0.3 -> 0.0.4 and fluttersdk_artisan ^0.0.6 -> ^0.0.8. Required for co-installability with fluttersdk_dusk 0.0.7 (which needs artisan ^0.0.8) inside a downstream package. No public API change.
  • telescope:install now injects import 'package:magic_devtools/telescope.dart'; (the Magic telescope adapter moved out of magic core into magic_devtools) and gates the magic-side wiring on a magic_devtools dependency (_hasMagicDevtoolsDep), so a magic-only consumer never gets an unresolvable import.

Verification

  • dart analyze 0 issues, dart format clean, 253 tests green, dart pub publish --dry-run clean (resolves against artisan 0.0.8).

Generated via /ac:execute (plan: magic-stabilize-dusk-telescope).

…evtools dep

telescope:install injected the now-removed package:magic/telescope_integration.dart
import (the adapter moved to the magic_devtools package). Repoint the injected
import to package:magic_devtools/telescope.dart and gate the magic-side wiring
on a magic_devtools dependency (_hasMagicDevtoolsDep).
Copilot AI review requested due to automatic review settings June 16, 2026 23:44
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the 0.0.4 release of fluttersdk_telescope, updating the fluttersdk_artisan dependency to ^0.0.8 and repointing the Magic integration injected by telescope:install to the new magic_devtools telescope barrel so downstream dependency resolution remains compatible.

Changes:

  • Bump package version to 0.0.4 and update fluttersdk_artisan constraint to ^0.0.8.
  • Update telescope:install to inject import 'package:magic_devtools/telescope.dart'; and gate Magic wiring on a magic_devtools dependency.
  • Update tests, example metadata, and changelog entries to match the new release/integration behavior.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/src/commands/telescope_install_command.dart Switch Magic integration injection to magic_devtools and update dependency detection helper.
test/src/commands/telescope_install_command_test.dart Adjust Magic install command test expectations to the new injected import path.
pubspec.yaml Bump version to 0.0.4 and update fluttersdk_artisan constraint to ^0.0.8.
example/pubspec.yaml Update example’s referenced telescope version to 0.0.4.
example/pubspec.lock Refresh lockfile to reflect artisan 0.0.8 and telescope 0.0.4.
CHANGELOG.md Add unreleased/release notes for Magic import repoint and artisan constraint bump.

Comment on lines +193 to 197
if (_hasMagicDevtoolsDep()) {
MainDartEditor.addImport(
mainDartPath,
"import 'package:magic/telescope_integration.dart';",
"import 'package:magic_devtools/telescope.dart';",
);
Comment on lines +212 to +214
/// Returns true when the consumer's pubspec.yaml lists `magic_devtools:`
/// (the package that ships MagicTelescopeIntegration) as a dependency or
/// dev_dependency (2-space indent).
anilcancakir added a commit that referenced this pull request Jun 17, 2026
@anilcancakir anilcancakir merged commit c3838be into master Jun 17, 2026
3 checks passed
@anilcancakir anilcancakir deleted the release/0.0.4 branch June 17, 2026 10:12
@anilcancakir

Copy link
Copy Markdown
Contributor Author

Both Copilot review notes were addressed in c738a1b (gate the magic_devtools import on a real Magic.init anchor via hasMagicInit && _hasMagicDevtoolsDep() so a magic_devtools-but-no-Magic.init app gets no unused import; fix the dev_dependencies docblock wording; add a negative-case regression test). The 0.0.4 release + both fixes landed on master (254 tests green, analyze/format clean).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants