docs(claude): adopt GitHub Flow + Branching section#10
Merged
Conversation
- Add Golden Rule 7 (GitHub Flow) covering one long-lived master, task branches via PR, and the release-tag mechanism. - Add Branching section mirroring fluttersdk_dusk: kebab-case task branches cut from master, squash-merge only, head auto-deletes. - Companion infra: develop branch deleted, repo set to squash-only with deleteBranchOnMerge=true, master protected (PR required).
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Documents the GitHub Flow branching convention adopted by the repo, codifying it in both CLAUDE.md and .github/copilot-instructions.md.
Changes:
- Add Golden Rule 7 ("GitHub Flow") summarizing the workflow.
- Add a new
## Branchingsection detailing task branch naming, release PR shape, and contributor flow. - Mirror the same content in
.github/copilot-instructions.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CLAUDE.md | Adds Golden Rule 7 and a Branching section describing the GitHub Flow process. |
| .github/copilot-instructions.md | Mirrors the same Golden Rule 7 and Branching section for Copilot guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codifies the GitHub Flow we now run in this repo, mirroring
fluttersdk_dusk:master), every task on its own kebab-case branch, PR back intomaster.release: X.Y.ZPR that bumpspubspec.yaml+ promotes## [Unreleased], then a tag push triggerspublish.yml.developaccumulator (thedevelopbranch was deleted alongside this change).Changes
CLAUDE.md: add Golden Rule 7 (GitHub Flow) +## Branchingsection.Companion infra (already applied)
developbranch deleted (local + remote).deleteBranchOnMerge: true,allowSquashMerge: true,allowMergeCommit: false,allowRebaseMerge: false.masterbranch protection enabled (PR required, no direct push).