fix(android): prevent crash if callbackInfo is null in BackgroundWorker (fixes #527) #615
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527
This PR prevents a
NullPointerException
whenFlutterCallbackInformation.lookupCallbackInformation(...)
returnsnull
inBackgroundWorker.kt
.Cause
If the stored callback handle (retrieved from
SharedPreferences
) is invalid or stale,lookupCallbackInformation(...)
returnsnull
. The existing code attempts to accesscallbackInfo.callbackLibraryPath
without checking for null, which crashes the app.Fix
Add a null check for
callbackInfo
and fail gracefully:This should prevent the app from terminating with an error such as those mentioned in the linked issue:
Attempt to read from field 'java.lang.String io.flutter.view.FlutterCallbackInformation.callbackLibraryPath'
EDIT: fixed compilation error on return thanks to @Tulleb