Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gradle and fix bug on android #985

Merged
merged 1 commit into from
Dec 30, 2024
Merged

upgrade gradle and fix bug on android #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
namespace = "vn.hunghd.flutterdownloader"
compileSdk = 34
compileSdk = 35

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand All @@ -45,7 +45,7 @@ android {

defaultConfig {
minSdk = 21
targetSdk = 34
targetSdk = 35
}
}

Expand Down
2 changes: 1 addition & 1 deletion android/src/main/kotlin/vn/hunghd/flutterdownloader/TaskDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class TaskDao(private val dbHelper: TaskDbHelper) {

fun loadTasksWithRawQuery(query: String?): List<DownloadTask> {
val db = dbHelper.readableDatabase
val cursor = db.rawQuery(query, null)
val cursor = db.rawQuery(query!!, null)
val result: MutableList<DownloadTask> = ArrayList()
while (cursor.moveToNext()) {
result.add(parseCursor(cursor))
Expand Down
4 changes: 2 additions & 2 deletions example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ if (flutterVersionName == null) {

android {
namespace = "vn.hunghd.example"
compileSdk = 34
compileSdk = 35
ndkVersion = flutter.ndkVersion

defaultConfig {
applicationId "vn.hunghd.example"
minSdk = 21
targetSdk = 34
targetSdk = 35
versionCode = flutterVersionCode.toInteger()
versionName = flutterVersionName
}
Expand Down
2 changes: 1 addition & 1 deletion example/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
2 changes: 1 addition & 1 deletion example/android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pluginManagement {

plugins {
id("dev.flutter.flutter-plugin-loader")
id("com.android.application") version ("8.3.1") apply false
id("com.android.application") version ('8.7.2') apply false
id("org.jetbrains.kotlin.android") version ("1.9.23") apply false
}

Expand Down
Loading