[Android] Add a delay before displaying progress indicator #623

henri2h · 2022-04-01T16:19:06Z

After a bit of digging in the video_player, I managed to enhance the seeking performance.

However, with this when seeking, it's frequent to have dozen of milliseconds between STATE_BUFFERING and STATE_READY. This makes the CircularProgressIndicator be displayed during a few milliseconds.

To prevent this, we propose to introduce a bit of temporization between the first isBuffering status and displaying the CircularProgressIndicator.

Proposal	Actual

Currently, an arbitrary timeout of 200ms has been chosen.

Linked pull request : flutter/plugins#5145

NB: This proposal only edit the material_control version of the player. I can edit the other view if you are willing to accept this proposal.

diegotori · 2022-04-01T16:24:02Z

@henri2h so that linked PR is currently awaiting testing, so until that one gets merged into the next video_player release, I'm gonna hold off on this. We also have to determine if the same change in that linked PR will be made to iOS, since right now, this only affects Android.

diegotori · 2022-04-01T16:25:32Z

However, if that Linked PR doesn't get approved, then I'll review. Can you modify the example app so that it's able to play content that evaluates this proposed change?

diegotori · 2022-04-01T16:26:50Z

Ideally speaking, if this was controlled by the ChewieController, so that the user can determine whether to enable this functionality, that would also be ideal.

henri2h · 2022-04-01T16:33:25Z

However, if that Linked PR doesn't get approved, then I'll review. Can you modify the example app so that it's able to play content that evaluates this proposed change?

Will do this on monday :)

henri2h · 2022-04-04T09:33:05Z

Lint is failing due to import from git repo but that's due to waiting for the upstream PR

henri2h · 2022-04-11T09:41:50Z

After some discussion, it was pointed out that the same effect could be achieved in the callback of the seekbar which is simpler and more elegant.

So this PR doesn't require anymore external PR.

@diegotori what do you think ? Do you want me to add the support for the CirculaProgressIndicator display delay to the other theme ?

diegotori · 2022-04-12T15:10:06Z

@henri2h is this occurring on iOS as well? If so, it would make sense to also add the delay there if and only if it occurs on iOS.

lib/src/chewie_player.dart

henri2h · 2022-04-12T15:40:16Z

@henri2h is this occurring on iOS as well? If so, it would make sense to also add the delay there if and only if it occurs on iOS.

I don't think so, but I don't have a mac so can't really test it.

diegotori · 2022-04-12T15:41:56Z

In that case, I'll have to take a look at it later today.

example/lib/app/app.dart

pubspec.yaml

example/lib/app/app.dart

maherjaafar · 2022-04-22T09:32:18Z

example/lib/app/app.dart

@@ -302,9 +310,78 @@ class _ChewieDemoState extends State<ChewieDemo> {
                ),
              ],
            ),
+            if (Platform.isAndroid)


Why not using it for iOS and Android?

I don't have any apple device so I can't test on iOS and don't want to modify things that I'm not sure it properly works / is needed.

example/lib/app/app.dart

diegotori · 2022-05-13T22:04:54Z

LGTM

diegotori · 2022-05-13T22:05:31Z

@brianegan I'm curious about your thoughts on this change, whenever you're able to chime in. Thanks in advance.

brianegan

Overall I think the solution makes sense, but it would be cool to see it applied to both Cupertino and Material controls. That will ensure feature parity and make future maintenence easier.

example/lib/app/app.dart

lib/src/chewie_player.dart

lib/src/progress_bar.dart

diegotori · 2022-05-19T03:37:56Z

Please re-sync your changes with master's current changes. Thanks.

diegotori · 2022-05-19T03:39:35Z

Once you re-sync the branch, I'm gonna attempt to smoke test these changes on my end, in particular with an iOS Simulator. If all works well after that, then I would say this PR is ready for release.

henri2h · 2022-06-01T08:36:00Z

Changes re synced with master, did you had time to review the changes ? Thanks !

diegotori · 2022-06-01T11:04:12Z

@henri2h not yet. Will attempt to do so today or tonight. Thank you for your patience.

diegotori · 2022-06-03T18:30:05Z

@henri2h After running your changes, looks like the webm file in the example app is not loading in iOS at all. Apparently, the iOS video_player doesn't seem to like webm files. Can you please replace it with an alternate video, preferably in MP4 format, so that I can further evaluate your changes? Thanks in advance.

diegotori · 2022-06-03T18:45:03Z

However, when I replaced the suspect video link with this one, it did work. So far no issues when I used that video.

Please edit the example app and replace the current webm video with either this one or another one of your choice. Thanks.

henri2h · 2022-06-07T08:31:59Z

However, when I replaced the suspect video link with this one, it did work. So far no issues when I used that video.

Please edit the example app and replace the current webm video with either this one or another one of your choice. Thanks.

Done ;)

diegotori · 2022-06-08T14:24:59Z

LGTM. Thanks for all of your hard work, @henri2h.

henri2h · 2022-06-08T14:27:30Z

thanks!

…y#646.

* commit '3948d23733638d8a58ea5ff065abfe96934d2373': (110 commits) Version 1.3.4. Addresses PRs fluttercommunity#623 and fluttercommunity#646. Update pubspec.yaml version updates fix: change video type fix: format and migration artifacts fix: apply diegotori suggestion feat: added support for apple and desktop version feat: Make progressIndicatorDelay a Duration fix: simplify assignation fix: name fix: let the android player buffer before seeking once more fix: removed old code fix: lint feat: added method to set progress delay feat: added example debug feat: add a delay before displaying progress indicator Version 1.3.3. Adds PR fluttercommunity#634. Update pubspec.yaml chore: remove unused dependency Version 1.3.2. Adds PR fluttercommunity#626. ... # Conflicts: # example/ios/Runner.xcodeproj/project.pbxproj # example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme # example/ios/Runner/Info.plist # example/lib/main.dart # example/pubspec.yaml # lib/src/chewie_player.dart # pubspec.yaml

henri2h force-pushed the temporized-buffering-status branch from dc356b5 to 1f51318 Compare April 4, 2022 09:31

henri2h force-pushed the temporized-buffering-status branch from 1f51318 to b2ea6eb Compare April 4, 2022 09:36

This was referenced Apr 6, 2022

[video_player] Seeking through the video without waiting for the player to be ready make the player unresponsive for a few seconds - Android only flutter/flutter#101409

Closed

[video_player] Increase seeking performance flutter/plugins#5145

Closed

henri2h changed the title ~~Add a delay before displaying progress indicator~~ [Anrdoid] Add a delay before displaying progress indicator Apr 11, 2022

henri2h changed the title ~~[Anrdoid] Add a delay before displaying progress indicator~~ [Android] Add a delay before displaying progress indicator Apr 11, 2022

diegotori reviewed Apr 12, 2022

View reviewed changes

lib/src/chewie_player.dart Outdated Show resolved Hide resolved

diegotori reviewed Apr 12, 2022

View reviewed changes

example/lib/app/app.dart Outdated Show resolved Hide resolved

henri2h commented Apr 20, 2022

View reviewed changes

pubspec.yaml Outdated Show resolved Hide resolved

example/lib/app/app.dart Outdated Show resolved Hide resolved

maherjaafar reviewed Apr 22, 2022

View reviewed changes

diegotori reviewed May 11, 2022

View reviewed changes

example/lib/app/app.dart Outdated Show resolved Hide resolved

brianegan reviewed May 14, 2022

View reviewed changes

example/lib/app/app.dart Outdated Show resolved Hide resolved

lib/src/chewie_player.dart Outdated Show resolved Hide resolved

diegotori reviewed May 17, 2022

View reviewed changes

lib/src/progress_bar.dart Show resolved Hide resolved

henri2h added 4 commits May 19, 2022 15:15

feat: add a delay before displaying progress indicator

32ca67e

feat: added example debug

106a885

feat: added method to set progress delay

09f3b95

fix: lint

4b69e85

henri2h added 8 commits May 19, 2022 15:17

fix: removed old code

26544dd

fix: let the android player buffer before seeking once more

4e99b4e

fix: name

82d658f

fix: simplify assignation

63b9756

feat: Make progressIndicatorDelay a Duration

a75b67c

feat: added support for apple and desktop version

72ef34e

fix: apply diegotori suggestion

28d63b2

fix: format and migration artifacts

79bfde8

henri2h force-pushed the temporized-buffering-status branch from 1e62c9f to 79bfde8 Compare May 19, 2022 13:20

fix: change video type

491becd

diegotori merged commit 7b3b839 into fluttercommunity:master Jun 8, 2022

diegotori added a commit that referenced this pull request Jun 21, 2022

Version 1.3.4. Addresses PRs #623 and #646.

3948d23

codenameakshay pushed a commit to qoohoo-app/chewie that referenced this pull request Aug 29, 2022

Version 1.3.4. Addresses PRs fluttercommunity#623 and fluttercommunit…

2f4d7bd

…y#646.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Add a delay before displaying progress indicator #623

[Android] Add a delay before displaying progress indicator #623

henri2h commented Apr 1, 2022 •

edited

Loading

diegotori commented Apr 1, 2022

diegotori commented Apr 1, 2022

diegotori commented Apr 1, 2022

henri2h commented Apr 1, 2022 •

edited

Loading

henri2h commented Apr 4, 2022

henri2h commented Apr 11, 2022 •

edited

Loading

diegotori commented Apr 12, 2022

henri2h commented Apr 12, 2022

diegotori commented Apr 12, 2022

maherjaafar Apr 22, 2022

henri2h Apr 22, 2022

diegotori commented May 13, 2022

diegotori commented May 13, 2022

brianegan left a comment

diegotori commented May 19, 2022

diegotori commented May 19, 2022

henri2h commented Jun 1, 2022 •

edited

Loading

diegotori commented Jun 1, 2022

diegotori commented Jun 3, 2022

diegotori commented Jun 3, 2022 •

edited

Loading

henri2h commented Jun 7, 2022

diegotori commented Jun 8, 2022

henri2h commented Jun 8, 2022

[Android] Add a delay before displaying progress indicator #623

[Android] Add a delay before displaying progress indicator #623

Conversation

henri2h commented Apr 1, 2022 • edited Loading

diegotori commented Apr 1, 2022

diegotori commented Apr 1, 2022

diegotori commented Apr 1, 2022

henri2h commented Apr 1, 2022 • edited Loading

henri2h commented Apr 4, 2022

henri2h commented Apr 11, 2022 • edited Loading

diegotori commented Apr 12, 2022

henri2h commented Apr 12, 2022

diegotori commented Apr 12, 2022

maherjaafar Apr 22, 2022

Choose a reason for hiding this comment

henri2h Apr 22, 2022

Choose a reason for hiding this comment

diegotori commented May 13, 2022

diegotori commented May 13, 2022

brianegan left a comment

Choose a reason for hiding this comment

diegotori commented May 19, 2022

diegotori commented May 19, 2022

henri2h commented Jun 1, 2022 • edited Loading

diegotori commented Jun 1, 2022

diegotori commented Jun 3, 2022

diegotori commented Jun 3, 2022 • edited Loading

henri2h commented Jun 7, 2022

diegotori commented Jun 8, 2022

henri2h commented Jun 8, 2022

henri2h commented Apr 1, 2022 •

edited

Loading

henri2h commented Apr 1, 2022 •

edited

Loading

henri2h commented Apr 11, 2022 •

edited

Loading

henri2h commented Jun 1, 2022 •

edited

Loading

diegotori commented Jun 3, 2022 •

edited

Loading