Add Flutter Linux merged threads migration annoucement #12534
Conversation
Raise awareness that Flutter FIXME:RELEASED_VERSION merged the UI/platform threads on Linux. This is a significant internal change that _might_ break apps. If so, we'd like customers to reach out to us on GitHub so that we can fix bugs, if any.
Summary of ChangesHello @robert-ancell, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces crucial documentation to inform Flutter users about a significant internal architectural change on Linux: the merging of UI and platform threads. This modification, while standardizing behavior across platforms, has the potential to impact existing applications. The primary objective is to proactively communicate this breaking change and establish a clear channel for users to report any issues, thereby ensuring the continued stability and smooth evolution of Flutter applications on the Linux platform. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
This is essentially a copy of #12440 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new breaking change announcement for merged threads on Linux. The changes include adding the announcement to the index and creating a new markdown file with the details. My review focuses on consistency and adherence to the repository's documentation standards. I've pointed out a placeholder inconsistency and some sorting issues in the index file. Overall, the content of the announcement is clear and well-written.
| * [`$FLUTTER_ROOT/version` replaced by `$FLUTTER_ROOT/bin/cache/flutter.version.json`][] | ||
| * [SnackBar with action no longer auto-dismisses][] | ||
| * [Deprecate `SemanticsProperties.focusable` and `SemanticsConfiguration.isFocusable`][] | ||
| * [Merged threads on Linux][] |
There was a problem hiding this comment.
According to line 41, this list should be in alphabetical order. This new entry is appended at the end, not in alphabetical order. Please place it in the correct alphabetical position to follow the documented convention.
| [`$FLUTTER_ROOT/version` replaced by `$FLUTTER_ROOT/bin/cache/flutter.version.json`]: /release/breaking-changes/flutter-root-version-file | ||
| [SnackBar with action no longer auto-dismisses]: /release/breaking-changes/snackbar-with-action-behavior-update | ||
| [Deprecate `SemanticsProperties.focusable` and `SemanticsConfiguration.isFocusable`]: /release/breaking-changes/deprecate-focusable | ||
| [Merged threads on Linux]: /release/breaking-changes/linux-merged-threads |
There was a problem hiding this comment.
Similar to the list of breaking changes, this list of link definitions should also be in alphabetical order based on the rule on line 41. Please place this new link definition in the correct alphabetical position.
|
|
||
| ## Description of change | ||
|
|
||
| Flutter FIXME:Next version merges the UI and platform threads by default on Linux. |
There was a problem hiding this comment.
This placeholder FIXME:Next version is inconsistent with FIXME:RELEASE_VERSION used elsewhere in the file (lines 4, 9, 36). To maintain consistency, please use FIXME:RELEASE_VERSION here as well.
| Flutter FIXME:Next version merges the UI and platform threads by default on Linux. | |
| Flutter FIXME:RELEASE_VERSION merges the UI and platform threads by default on Linux. |
|
@loic-sharma I'm not sure what version numbers to put in here - is there a number for the next release I should use or remove these numbers? |
|
Visit the preview URL for this PR (updated for commit c6f61e6): https://flutter-docs-prod--pr12534-linux-merged-threads-d6qcedwn.web.app |
|
@robert-ancell The placeholders are fine for now :) FYI @flutter/website-reviewers, this change (flutter/flutter#176759) is NOT in the upcoming 3.38 release. It'll land in the subsequent release. |
3 participants
Raise awareness that Flutter FIXME:RELEASED_VERSION merged the UI/platform threads on Linux. This is a significant internal change that might break apps. If so, we'd like customers to reach out to us on GitHub so that we can fix bugs, if any.