Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-11599: update dart:js_interop hyperlink #11600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CellCS
Copy link

@CellCS CellCS commented Jan 17, 2025

…o dart-js_interop/dart-js_interop-library.html

Description of what this PR is changing or adding, and why:

Issue:

Hyperlink is now working of [dart:js_interop]: {{site.dart.api}}/{{site.dart.sdk.channel}}/dart-js_interop

image

image

Fix dart:js_interop hyperlink by updating:

Issues fixed by this PR (if any):

image

PRs or commits this PR depends on (if any): Fixes #11599

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@CellCS CellCS requested review from sfshaza2, antfitch, parlough and a team as code owners January 17, 2025 17:43
Copy link

google-cla bot commented Jan 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 17, 2025

Visit the preview URL for this PR (updated for commit de03fcb):

https://flutter-docs-prod--pr11600-issue-11599-js-interop-libr-ibk4phkl.web.app

@CellCS
Copy link
Author

CellCS commented Jan 17, 2025

Testing:

Prebuild: https://flutter-docs-prod--pr11600-issue-11599-js-interop-libr-ibk4phkl.web.app/platform-integration/web/wasm

Tools: macOS, Chrome.

Result: dart:js_interop library page is loaded and showing up.

image image

@CellCS
Copy link
Author

CellCS commented Jan 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Done!
Cheers

@piedcipher piedcipher force-pushed the issue/11599-js_interop-library_hyperlink branch from 2d236cb to 66d782c Compare January 17, 2025 18:57
@piedcipher
Copy link
Member

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

Done! Cheers

CLA still fails, could you please check one more time?

@CellCS
Copy link
Author

CellCS commented Jan 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

Done! Cheers

CLA still fails, could you please check one more time?

Thanks for remind,

The issue maybe because my local git email

git config -l | grep user.email 
[email protected]

and CLA shows error about
image

sorry to take your more effort and help, i am not sure how to use "[email protected]" to pass CLA? would you mind give me some suggestion?

@piedcipher
Copy link
Member

piedcipher commented Jan 17, 2025

You can set the email you used for the CLA with the git config command and update your commit using --amend.

git config user.email your_cla_email && git commit --amend

Or you could re-do cla with the email used in commit.

No worries at all - happy to help! Let me know if you have any questions or need further assistance.

@piedcipher
Copy link
Member

I noticed there's a new commit. While a force push would have resolved this completely, you can now squash the commits to tidy things up.

…o dart-js_interop/dart-js_interop-library.html
…o dart-js_interop/dart-js_interop-library.html
@CellCS CellCS force-pushed the issue/11599-js_interop-library_hyperlink branch from b9e3b18 to de03fcb Compare January 17, 2025 19:47
@CellCS
Copy link
Author

CellCS commented Jan 17, 2025

I noticed there's a new commit. While a force push would have resolved this completely, you can now squash the commits to tidy things up.

@piedcipher Thank you so much, much appreciated! You also help me to fix my local git config issue. thanks a lot for your kind help and support. looks cla/google is passed. Please review.

@piedcipher
Copy link
Member

piedcipher commented Jan 17, 2025

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

**js_interop library** hyperlink issue in Support for WebAssembly (Wasm) page
4 participants