-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-11599: update dart:js_interop hyperlink #11600
base: main
Are you sure you want to change the base?
Issue-11599: update dart:js_interop hyperlink #11600
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
Visit the preview URL for this PR (updated for commit de03fcb): https://flutter-docs-prod--pr11600-issue-11599-js-interop-libr-ibk4phkl.web.app |
Done! |
2d236cb
to
66d782c
Compare
CLA still fails, could you please check one more time? |
Thanks for remind, The issue maybe because my local git email
sorry to take your more effort and help, i am not sure how to use "[email protected]" to pass CLA? would you mind give me some suggestion? |
You can set the email you used for the CLA with the git config command and update your commit using --amend.
Or you could re-do cla with the email used in commit. No worries at all - happy to help! Let me know if you have any questions or need further assistance. |
I noticed there's a new commit. While a force push would have resolved this completely, you can now squash the commits to tidy things up. |
…o dart-js_interop/dart-js_interop-library.html
…o dart-js_interop/dart-js_interop-library.html
b9e3b18
to
de03fcb
Compare
@piedcipher Thank you so much, much appreciated! You also help me to fix my local git config issue. thanks a lot for your kind help and support. looks cla/google is passed. Please review. |
/gcbrun |
…o dart-js_interop/dart-js_interop-library.html
Description of what this PR is changing or adding, and why:
Issue:
Hyperlink is now working of
[dart:js_interop]: {{site.dart.api}}/{{site.dart.sdk.channel}}/dart-js_interop
Fix dart:js_interop hyperlink by updating:
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any): Fixes #11599
Presubmit checklist