Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with info on survey metadata in Cloud Build #121

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Update README with info on survey metadata in Cloud Build #121

merged 3 commits into from
Oct 26, 2023

Conversation

khanhnwin
Copy link
Contributor

@jayoung-lee will likely be the only person who needs access to confirm the survey metadata gets uploaded, but I wanted to document it just in case.

drewroengoogle
drewroengoogle approved these changes Oct 26, 2023
View reviewed changes
Copy link

@drewroengoogle drewroengoogle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! One nit is that it might be good to add to the readme that the commit on github will also show the cloud build and take you directly to the results/logs.

Example of the most recent commit:
Screenshot 2023-10-26 at 1 52 54 PM

@khanhnwin khanhnwin merged commit 3ba834e into master Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroengoogle drewroengoogle drewroengoogle approved these changes

@jayoung-lee jayoung-lee Awaiting requested review from jayoung-lee

@parlough parlough Awaiting requested review from parlough

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanhnwin @drewroengoogle