Update the metadata for the survey pilot testing #2 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: ID, date, URL, condition, etc. TODO: update the description
eliasyishak
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Sorry for the delayed response on this!
But LGTM, just curious though.. i'm just realizing that for us to use the flutter channel as a conditional, I am assuming that the channel that is reported by Flutter is beta.
Is this always how Flutter will report that channel? ie. can it vary in casing such as BETA, Beta, etc?
EDIT: Nevermind, I can confirm from the flutter tool code that it will always be lowercase
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/version.dart#L45-L50
eliasyishak
suggested changes
Oct 26, 2023
|
Updated! |
|
Thank you :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated: ID, date, URL, condition, etc.
TODO: update the description if needed