[file_selector] Add parameter to control whether the new folders button is visible in the file dialog #9965

danferreira · 2025-09-06T00:59:15Z

Adds a new parameter canCreateDirectories to FileDialogOptions to control the visibility of the New Folder button in file dialogs on supported platforms.

Currently only configurable on Linux and macOS

This is the "Combined PR"
Let me know if we are okay with this approach so I can open a new PR covering the interface changes

Fixes: flutter/flutter#141339

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

stuartmorgan-g

Thanks for the contribution!

stuartmorgan-g · 2025-09-10T13:30:20Z

packages/file_selector/file_selector/lib/file_selector.dart

 ///
+/// [canCreateDirectories] controls whether the user is allowed to create new
+/// directories in the dialog (if supported on the platform).
+/// Currently only supported on Linux and macOS.


The app-facing package has no control over this, so it's subject to becoming stale (and misleading about unendorsed implementations). It should just say that it may not be supported on all platforms.

Agree. I changed the doc so that it infers less about the implementations
Let me know what you think

stuartmorgan-g · 2025-09-10T13:30:38Z

packages/file_selector/file_selector/CHANGELOG.md

-## NEXT
+## 1.1.0

+* Adds `canCreateDirectories` parameter to `FileDialogOptions` to control the visibility of the New Folder button in file dialogs on supported platforms.


FileDialogOptions shouldn't be mentioned at this level, since it's not the public API here.

Makes total sense.

Fixed manually all changelogs

packages/file_selector/file_selector/lib/file_selector.dart

stuartmorgan-g · 2025-09-10T13:32:16Z

packages/file_selector/file_selector/test/file_selector_test.dart

  const String initialDirectory = '/home/flutteruser';
  const String confirmButtonText = 'Use this profile picture';
  const String suggestedName = 'suggested_name';
+  const bool canCreateDirectories = true;


There's no need for this to be stateful in the tests; values should be local.

stuartmorgan-g · 2025-09-10T13:33:39Z

...or/file_selector_platform_interface/lib/src/method_channel/method_channel_file_selector.dart

This file shouldn't be changed; it's for legacy compat, and legacy implementations won't support new features.

...tor/file_selector_platform_interface/lib/src/platform_interface/file_selector_interface.dart

packages/file_selector/file_selector_linux/lib/file_selector_linux.dart

packages/file_selector/file_selector_linux/linux/test/file_selector_plugin_test.cc

packages/file_selector/file_selector_macos/lib/file_selector_macos.dart

...elector_macos/macos/file_selector_macos/Sources/file_selector_macos/FileSelectorPlugin.swift

stuartmorgan-g

Sorry for the delay in getting back to this. A few more comments on the cross-platform parts.

stuartmorgan-g · 2025-10-10T15:21:43Z

packages/file_selector/file_selector/test/file_selector_test.dart

      expect(location?.path, expectedSavePath);
    });
+
+    test('sets to disable the creation of new directories', () async {


'sets the directory creation control flag'

stuartmorgan-g · 2025-10-10T15:21:55Z

packages/file_selector/file_selector/test/file_selector_test.dart

      expect(directoryPath, expectedDirectoryPath);
    });
+
+    test('sets to enable de creation of new directories', () async {


stuartmorgan-g · 2025-10-10T15:22:02Z

packages/file_selector/file_selector/test/file_selector_test.dart

      );
      expect(directoryPaths, expectedDirectoryPaths);
    });
+    test('sets to enable de creation of new directories', () async {


stuartmorgan-g · 2025-10-10T15:23:58Z

packages/file_selector/file_selector/CHANGELOG.md

-## NEXT
+## 1.1.0

+* Adds `canCreateDirectories` param to `getDirectoryPath` and `getDirectoryPaths` to control the visibility of the New Folder button in file dialogs on supported platforms.


This should not be describing an exact UI element, because this layer has no control over what the specific UI is.

Ah, I get it now. It makes sense.
I will describe the behavior instead.

stuartmorgan-g · 2025-10-10T15:33:56Z

...le_selector/file_selector_platform_interface/test/file_selector_platform_interface_test.dart

+  });
+
+  group('getDirectoryPathWithOptions', () {
+    test('Should throw unimplemented exception', () async {


Here and below: that's not what we want to test for the new methods. The implementations of the new methods should not throw UnimplementedError, because that would break backward compatibility when the app-facing package change lands. They must call the deprecated methods, and that's what the test should be testing.

I see.
I didn't even realize the getSaveLocation test was doing exactly what you described.
I'll update the mentioned tests to check if the deprecated methods were called.

danferreira · 2025-10-22T08:54:48Z

Sorry for the delay in getting back to this. A few more comments on the cross-platform parts.

I appreciate your patience
I'd never worked with a Flutter codebase before, so I was a bit confused by the plugin package structure.
But thanks to your comments, things are starting to make sense now.
Im learning a lot.

vashworth

iOS side LGTM

stuartmorgan-g

Overall this looks good; please go ahead and split out the platform interface initial PR now and we can get that reviewed and landed. (Normally we'd wait for all the platform reviews for that, but I've looked over all of them, and they are straightforward enough that we don't need to block the interface PR on that.)

gmackall

android portion lgtm

github-actions bot added p: file_selector platform-android platform-ios platform-linux platform-macos platform-web platform-windows labels Sep 6, 2025

danferreira marked this pull request as ready for review September 6, 2025 22:44

danferreira requested review from ditman, mboetger, stuartmorgan-g and vashworth as code owners September 6, 2025 22:44

stuartmorgan-g requested changes Sep 10, 2025

View reviewed changes

github-actions bot removed the platform-ios label Sep 11, 2025

danferreira requested a review from stuartmorgan-g September 11, 2025 04:32

stuartmorgan-g removed the request for review from ditman October 10, 2025 15:35

stuartmorgan-g reviewed Oct 10, 2025

View reviewed changes

stuartmorgan-g added triage-ios Should be looked at in iOS triage triage-android Should be looked at in Android triage labels Oct 10, 2025

danferreira force-pushed the file_selector-can-create-directories-param branch from cb4e65c to 0b3beb5 Compare October 22, 2025 00:08

danferreira requested review from Piinks, bkonyi, bparrishMines, camsim99, gmackall, mdebbar, parlough and tarrinneal as code owners October 22, 2025 00:08

github-actions bot added p: camera p: google_maps_flutter labels Oct 22, 2025

danferreira added 12 commits October 21, 2025 22:06

Apply format

92c4498

Fix tests

c6e44da

Implement platform interface

3ef6eb5

fix: pass the correct parameter to hostapi

e808fa4

tests: fix linux tests

8f3f9d6

fix: changelog and docs

3f5954d

fix: undo changes on method channel

8dc9a13

fix: tests

29b9948

adds createDirectories param to getSaveLocation

788fcfb

Fix file_selector_windows changelog

2e294ea

update runnerTests

95a8675

add parameter to getSaveLocation

397d15f

danferreira force-pushed the file_selector-can-create-directories-param branch from 0b3beb5 to 397d15f Compare October 22, 2025 01:13

github-actions bot removed p: camera p: google_maps_flutter p: google_sign_in p: image_picker p: local_auth p: webview_flutter p: url_launcher p: google_fonts labels Oct 22, 2025

danferreira added 2 commits October 22, 2025 04:57

Fix cr requests

59aaeab

Fix changelog for platform interface

0e6ec65

danferreira requested a review from stuartmorgan-g October 22, 2025 08:55

vashworth approved these changes Oct 23, 2025

View reviewed changes

stuartmorgan-g reviewed Oct 27, 2025

View reviewed changes

camsim99 removed their request for review October 27, 2025 16:48

gmackall approved these changes Oct 28, 2025

View reviewed changes

danferreira mentioned this pull request Oct 29, 2025

[file_selector] Add canCreateDirectories to FileDialogOptions #10317

Open

11 tasks

[file_selector] Add parameter to control whether the new folders button is visible in the file dialog #9965

Are you sure you want to change the base?

[file_selector] Add parameter to control whether the new folders button is visible in the file dialog #9965

Conversation

danferreira commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danferreira Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danferreira commented Oct 22, 2025

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danferreira commented Sep 6, 2025 •

edited

Loading

danferreira Sep 11, 2025 •

edited

Loading