[go_router_builder] [in_app_purchase_storekit] Removes redundant arguments from annotations

[FMorschel]

It was found, at the issue below, a false-negative for the avoid_redundant_argument_values lint where it wasn't triggered for annotations. This PR simply removes the redundant arguments.

• linter rule avoid_redundant_argument_values and annotation coverage dart-lang/sdk#61456

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[gemini-code-assist]

Code Review

This pull request focuses on code cleanup by removing redundant arguments in annotations, addressing a lint for avoid_redundant_argument_values. The changes are applied to TypedShellRoute annotations in test files for go_router_builder and a JsonKey annotation in in_app_purchase_storekit. The changes are straightforward and improve code conciseness.

[gemini-code-assist]

Thanks for removing the redundant defaultValue: null. However, it looks like the corresponding generated file, sk_product_wrapper.g.dart, hasn't been updated. As noted in the file header, changes to @JsonSerializable classes require running the build runner. Please run the generator and commit the updated .g.dart file to ensure the generated code is in sync with this change.

[chunhtai]

LGTM for go_router part

[LongCatIsLooong]

Hi @LouiseHsu this class doesn't seem to be read by anyone, and the code generator seems to be generating _$SKProductDiscountTypeEnumMap just fine without it being added to _SerializedEnums. Do you think this type can be removed?

[FMorschel]

and the code generator seems to be generating _$SKProductDiscountTypeEnumMap just fine without it being added to _SerializedEnums.

I couldn't do without it.

[LongCatIsLooong]

I'm not familiar with json_serializable.dart, but the following code already exists in enum_converters.g.dart today:

const _$SKProductDiscountTypeEnumMap = {
  SKProductDiscountType.introductory: 0,
  SKProductDiscountType.subscription: 1,
};

you mean if you rerun code gen the above map const is removed from the generated source code, without that new field in _SerializedEnums?

[FMorschel]

you mean if you rerun code gen the above map const is removed from the generated source code, without that new field

Exactly. See the second commit on this branch, I simply ran the build and pushed, expecting any diagnostics to be stale analysis that would get fixed once it was updated. Once I saw the bots failed, I actually looked at the output and diagnostics.

So I had to add that and remove the ? from the map key for it to build. It was also warning on the terminal (while building) about the annotations version, so I upgraded it as well.

I'm not sure why this line was missing, if it was removed by mistake or something, but it would not generate this without it.

[LongCatIsLooong]

The CI is complaining about missing versionbump / changelog (see: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates). The IAP change seems to involve a signature change, could you bump the version of that package?

[FMorschel]

I'd asked about it at #9964 (comment). Will do. Thanks!

[LongCatIsLooong]

@chunhtai do you think the go_router_builder change needs a version bump (I think that's blocking the CI)? If not I think we should put on the override tag.

[FMorschel]

do you think the go_router_builder change needs a version bump (I think that's blocking the CI)? If not I think we should put on the override tag.

@chunhtai, sorry for the new ping, but maybe you didn't see the one above?

[chunhtai]

reason for override, test only file formatting

[auto-submit]

autosubmit label was removed for flutter/packages/9964, because - The status or check suite Linux_desktop build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

[FMorschel]

It says the bot was cancelled (if I understood it correctly). Do I need to do anything?