-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Ensure Example Packages Work on Android API 36 #9241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
zipStoreBase=GRADLE_USER_HOME | |||
zipStorePath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add NL at EOF
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
zipStoreBase=GRADLE_USER_HOME | |||
zipStorePath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add NL at EOF
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
zipStoreBase=GRADLE_USER_HOME | |||
zipStorePath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add NL at EOF
Looks like the new toolchain is triggering some new lints that will need to be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, How did you update these projects? Did you use the android studio tool for updating the project or did you do something else?
I updated them manually. The values were dervied from the sdk 36 minimums from android docs here. I think to use the AGP upgrade tool, you would have to open each android project separately. |
@jesswrd Were you unable to get |
Before I started manually updating, I looked into the command you suggested. I concluded I didn't need to use it for my purposes because I actually didn't see you could use that command to update Gradle on my first pass. I just tried it and it works well. It doesn't look like the update dependency command includes updating AGP for example apps. |
Ensured the example plugin apps on Android work on Android API 36 by updating configurations and sucessfully running
flutter build apk
(means the app can successfully build + all dependencies are resolvable). For compatibility with Android API 36, the example plugin apps on Android should have the following configurations:targetSdk
: 36compileSdk
: 36AGP version: 8.9.1
Gradle version: 8.11.1
Most packages no longer require a manual bump of
targetSdk
andcompileSdk
due to usage of values from Flutter Gradle Plugin. Below is a list of example plugin apps on Android:Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3