-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Improve performance and remove flickers and enhance buffering #9237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Improved buffering handling in ExoPlayerEventListener to reduce flickering during playback state changes. - Added a throttling mechanism for buffering updates in VideoPlayer to prevent excessive UI updates. - Enhanced surface management in PlatformVideoView to avoid rendering issues and flickering during surface transitions. - Introduced TextureSurfaceHelper to manage surface texture transitions and prevent flickering during surface changes. - Updated TextureVideoPlayer to utilize TextureSurfaceHelper for smoother surface management. These changes collectively enhance the user experience by ensuring smoother playback and reducing visual artifacts during video transitions.
…onfigurations - Updated various build files and configurations for the video player example project to improve compatibility and performance across different architectures (arm64-v8a, armeabi-v7a, x86, x86_64). - Enhanced the Android Gradle build files to ensure smoother integration and build processes. - Made adjustments to the VideoPlayer.java, PlatformVideoView.java, TextureSurfaceHelper.java, and TextureVideoPlayer.java files to optimize video playback and surface management. These changes collectively aim to enhance the development experience and ensure better performance of the video player on Android devices.
- Updated README to indicate that Android SDK <21 is no longer supported. - Improved buffering performance with optimized memory usage. - Enhanced video loading speed with better resource management. - Reduced UI freezes during playback of high-resolution content. - Fixed stuttering issues on initial video playback. - Improved overall video playback performance across platforms.
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
#168114 |
@ianloic @sethladd @kevmoo @darrenaustin |
Thanks for the contribution!
Please re-read the contributor documentation linked from the PR checklist; the way reviewers is assigned is via a standard weekly triage process, not by pinging (random) people. You’ve checked boxes in the PR checklist above that are not reflected in this PR (e.g., both of the entries regarding testing), so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the state of the PR as posted reflects the checklist please feel free to mark it as ready for review. Also, as a general note, PRs that are scoped to specific issues are strongly preferred over PRs that make a variety of unrelated changes, so this should very likely be multiple PRs given the list of things in the PR description. |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3