[various] Add Swift Package Manager integration to example apps #8219

loic-sharma · 2024-12-03T22:54:40Z

This migrates various example apps to have Swift Package Manager integration. This raises the example apps' Flutter SDK requirement to 3.24.0 or higher.

I will get a text exemption for this change.

The example apps were migrated using the following commands:

dart run script/tool/bin/flutter_plugin_tools.dart build-examples --ios --swift-package-manager
dart run script/tool/bin/flutter_plugin_tools.dart build-examples --macos --swift-package-manager

⚠️ The following plugins' example apps are not included in this change as their migration included non-SPM changes that require closer review:

google_sign_in
google_sign_in_ios
image_picker
image_picker_ios
image_picker_macos
pigeon

Part of: flutter/flutter#159173

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma · 2024-12-03T22:58:47Z

packages/in_app_purchase/in_app_purchase/example/ios/Runner.xcodeproj/project.pbxproj

@@ -247,12 +255,10 @@
 			inputPaths = (
 				"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-resources.sh",
 				"${PODS_CONFIGURATION_BUILD_DIR}/in_app_purchase_storekit/in_app_purchase_storekit_privacy.bundle",
-				"${PODS_CONFIGURATION_BUILD_DIR}/shared_preferences_foundation/shared_preferences_foundation_privacy.bundle",


This is expected: in_app_purchase_storekit hasn't been migrated to SPM yet, but shared_preferences_foundation has.

loic-sharma · 2024-12-03T23:00:37Z

packages/local_auth/local_auth_darwin/example/ios/Runner.xcodeproj/project.pbxproj

@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 60;
+	objectVersion = 54;


I'm not sure why this was changed. However, this seems reasonable. Please let me know if you'd like me to revert this line.

IIRC this is just based on what version of Xcode was last used to write the project file; it shouldn't matter.

loic-sharma · 2024-12-03T23:02:16Z

packages/path_provider/path_provider_foundation/example/ios/Runner.xcodeproj/project.pbxproj

@@ -471,7 +461,6 @@
 				CLANG_ENABLE_MODULES = YES;
 				CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
 				CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)";
-				// DEVELOPMENT_TEAM = S8QB4VV633;


FYI this isn't related to SPM but is a reasonable change

loic-sharma · 2024-12-03T23:13:53Z

packages/webview_flutter/webview_flutter_wkwebview/example/ios/Runner.xcodeproj/project.pbxproj

@@ -3,14 +3,15 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 60;
+	objectVersion = 54;


Same comment as #8219 (comment)

flutter-dashboard · 2024-12-04T00:20:24Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

tarrinneal

Shared Prefs approval

LouiseHsu

in app purchase ell gee tee em

stuartmorgan · 2024-12-04T14:56:44Z

test-exempt: configuration change

cbracken

lgtm for google maps!

stuartmorgan

LGTM for all packages

…apps (flutter/packages#8219)

flutter/packages@bc0c22d...45bcc32 2024-12-05 [email protected] [various] Add Swift Package Manager integration to Google sign in example apps (flutter/packages#8230) 2024-12-05 [email protected] Roll Flutter from e1e4ee9 to ab5b20c (7 revisions) (flutter/packages#8236) 2024-12-05 [email protected] [various] Update iOS/macOS Pigeon versions (flutter/packages#8226) 2024-12-05 [email protected] [ci] Adds google_adsense to labeler.yml (flutter/packages#8231) 2024-12-05 [email protected] [pigeon] adds event channel support for kotlin and swift (flutter/packages#7892) 2024-12-04 [email protected] [google_adsense] (Experimental) AdSense plugin for Flutter Web (flutter/packages#6871) 2024-12-04 [email protected] [various] Add Swift Package Manager integration to image picker examp… (flutter/packages#8227) 2024-12-04 [email protected] [pigeon] Add Swift Package Manager integration to example app (flutter/packages#8225) 2024-12-04 [email protected] [video_player_avfoundation] Split iOS native code into multiple files (flutter/packages#8171) 2024-12-04 [email protected] Roll Flutter from e64ee5d to e1e4ee9 (18 revisions) (flutter/packages#8224) 2024-12-04 [email protected] [various] Add Swift Package Manager integration to example apps (flutter/packages#8219) 2024-12-04 [email protected] [google_maps_flutter] Annotate deprecated member usage (flutter/packages#8214) 2024-12-04 [email protected] [pigeon] Fixes channel names of the named constructors of ProxyApis. (flutter/packages#8201) 2024-12-03 [email protected] [local_auth] Add compatibility with intl 0.20 (flutter/packages#8217) 2024-12-03 [email protected] [various] Replaces deprecated `whereNotNull()` (flutter/packages#8215) 2024-12-03 [email protected] Roll Flutter from 08e26a3 to e64ee5d (20 revisions) (flutter/packages#8213) 2024-12-02 [email protected] [shared_preferences] Limit Android decoding (flutter/packages#8187) 2024-12-02 49699333+dependabot[bot]@users.noreply.github.com [camera_android]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/camera/camera_android/android (flutter/packages#8164) 2024-12-02 49699333+dependabot[bot]@users.noreply.github.com [gradle]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.21 to 2.1.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8205) 2024-11-28 [email protected] Roll Flutter from fae695e to 08e26a3 (19 revisions) (flutter/packages#8197) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

loic-sharma commented Dec 3, 2024

View reviewed changes

[various] Add Swift Package Manager integration to example apps

c5f3f9f

loic-sharma force-pushed the spm_example_apps_integration branch from b2f75ea to c5f3f9f Compare December 3, 2024 23:08

loic-sharma commented Dec 3, 2024

View reviewed changes

loic-sharma marked this pull request as ready for review December 4, 2024 00:19

loic-sharma requested review from cbracken, hellohuanlin, jmagman and tarrinneal as code owners December 4, 2024 00:19

loic-sharma requested review from LouiseHsu, bparrishMines, Hixie, ditman, stuartmorgan and chunhtai as code owners December 4, 2024 00:19

tarrinneal approved these changes Dec 4, 2024

View reviewed changes

LouiseHsu approved these changes Dec 4, 2024

View reviewed changes

cbracken approved these changes Dec 4, 2024

View reviewed changes

stuartmorgan approved these changes Dec 4, 2024

View reviewed changes

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 4, 2024

auto-submit bot merged commit bd8dafa into flutter:main Dec 4, 2024
77 checks passed

engine-flutter-autoroll mentioned this pull request Dec 6, 2024

Roll Packages from bc0c22d57910 to 45bcc3210fcc (20 revisions) flutter/flutter#159885

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2024

bd8dafac6 [various] Add Swift Package Manager integration to example …

70d50e7

…apps (flutter/packages#8219)

engine-flutter-autoroll mentioned this pull request Dec 6, 2024

Roll Packages from bc0c22d57910 to 45bcc3210fcc (20 revisions) flutter/flutter#159900

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2024

bd8dafac6 [various] Add Swift Package Manager integration to example …

4e13883

…apps (flutter/packages#8219)

engine-flutter-autoroll mentioned this pull request Dec 9, 2024

Roll Packages from bc0c22d57910 to 45bcc3210fcc (20 revisions) flutter/flutter#159978

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2024

bd8dafac6 [various] Add Swift Package Manager integration to example …

00b5b5d

…apps (flutter/packages#8219)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[various] Add Swift Package Manager integration to example apps #8219

[various] Add Swift Package Manager integration to example apps #8219

loic-sharma commented Dec 3, 2024 •

edited

Loading

loic-sharma Dec 3, 2024

loic-sharma Dec 3, 2024 •

edited

Loading

stuartmorgan Dec 4, 2024

loic-sharma Dec 3, 2024

loic-sharma Dec 3, 2024

flutter-dashboard bot commented Dec 4, 2024

tarrinneal left a comment

LouiseHsu left a comment

stuartmorgan commented Dec 4, 2024

cbracken left a comment

stuartmorgan left a comment

[various] Add Swift Package Manager integration to example apps #8219

[various] Add Swift Package Manager integration to example apps #8219

Conversation

loic-sharma commented Dec 3, 2024 • edited Loading

Pre-launch Checklist

loic-sharma Dec 3, 2024

Choose a reason for hiding this comment

loic-sharma Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

stuartmorgan Dec 4, 2024

Choose a reason for hiding this comment

loic-sharma Dec 3, 2024

Choose a reason for hiding this comment

loic-sharma Dec 3, 2024

Choose a reason for hiding this comment

flutter-dashboard bot commented Dec 4, 2024

tarrinneal left a comment

Choose a reason for hiding this comment

LouiseHsu left a comment

Choose a reason for hiding this comment

stuartmorgan commented Dec 4, 2024

cbracken left a comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

loic-sharma commented Dec 3, 2024 •

edited

Loading

loic-sharma Dec 3, 2024 •

edited

Loading