Skip to content

Conversation

@RobertOdrowaz
Copy link
Contributor

Migrates camera wrappers as part of flutter/flutter#119109

This PR migrates wrappers to Swift:

  • FLTCaptureConnection
  • FLTCaptureDeviceFormat
  • FLTAssetWriter

In line with Swift conventions, the FLT prefixes are removed. The Default class implementations are replaced with protocol conformance on base AV classes.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request continues the migration of Objective-C code to Swift by converting FLTCaptureConnection, FLTCaptureDeviceFormat, and FLTAssetWriter from wrapper classes to Swift protocols. This is a solid architectural improvement that makes the code more idiomatic and type-safe. The changes are consistently applied throughout the codebase, including tests and mocks. I have one minor suggestion to further align the code with Swift conventions.

func connection(with mediaType: AVMediaType) -> FLTCaptureConnection? {
guard let connection: AVCaptureConnection = connection(with: mediaType) else { return nil }
return FLTDefaultCaptureConnection(connection: connection)
func connection(with mediaType: AVMediaType) -> (any CaptureConnection)? {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The return type (any CaptureConnection)? can be simplified to CaptureConnection?. The any keyword is only required for protocols with Self or associated type requirements when used as a type, which is not the case for CaptureConnection. This change makes the signature more idiomatic.

Suggested change
func connection(with mediaType: AVMediaType) -> (any CaptureConnection)? {
func connection(with mediaType: AVMediaType) -> CaptureConnection? {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant