fix RECORD_AUDIO permission on Android when there is no permission

[agrapine]

Allows to record video without audio when we init the CameraController with enableAudio=false

 final controller = CameraController(
        camera.first,
        ResolutionPreset.high,
        enableAudio: false,
      );

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request aims to fix how audio recording is handled when permissions are missing or audio is disabled. While the intent is correct, the implementation contains a critical logical error that would mute audio when it should be enabled. Additionally, the corresponding unit tests have not been updated to reflect the new logic, which would cause them to fail. I've provided a detailed review comment on the withAudioEnabled method with a suggested fix and a reference to the testing guidelines.

[agrapine]

it seems that even when we start the CameraController(enableAudio:false) when starting to record video, if no permission was given for RECORD_AUDIO on android, it just throws an exeption saying the permission wasn't granted.

[camsim99]

Wow thanks so much for catching + fixing this subtle bug!

Before we land this, we'll need to test this. You'll just need to add/modify tests in PendingRecordingTest.java.

[camsim99]

Nit: can you add a comment about the default behavior

Suggested change

	return pigeonInstance;
	// By default, the recording will not contain audio.
	return pigeonInstance;

[stuartmorgan-g]

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.