[google_fonts] Make a map keyed on FontWeight non-const #10058
Conversation
A proposed engine PR will allow construction of arbitrary FontWeight instances and thus needs to overload the FontWeight equality operator (see flutter/flutter#175771) With that change it will no longer be possible to use FontWeight as the key in a const map.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google_fonts package by removing the const keyword from a map that uses FontWeight as a key. This change is necessary to support a proposed modification in the Flutter engine that will make FontWeight instances non-constant. The package version and changelog are updated accordingly to reflect this change. My review includes a suggestion to mark the map as final to improve code robustness.
packages/google_fonts/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 6.3.2 | |||
|
|
|||
| - Make a map keyed on FontWeight non-const for compatibility with proposed changes to the engine's implementation of FontWeight. | |||
There was a problem hiding this comment.
jason-simmons
added
the
autosubmit
A proposed engine PR will allow construction of arbitrary FontWeight instances and thus needs to overload the FontWeight equality operator (see flutter/flutter#175771)
With that change it will no longer be possible to use FontWeight as the key in a const map.