Skip to content

Update image assets in travel app catalog for information card and itinerary items #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −11
Open

Update image assets in travel app catalog for information card and itinerary items #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d56e29
Update image assets in travel app information and itinerary cards
victoreronmosele Nov 1, 2025
86427a1
Update image URL in Image component example data and test data
victoreronmosele Nov 1, 2025
54372f2
Merge branch 'main' into fix/travel-app-widget-catalog
victoreronmosele Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/travel_app/lib/src/catalog/information_card.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ final informationCard = CatalogItem(
"component": {
"Image": {
"url": {
"literalString": "assets/travel_images/beach.jpg"
"literalString": "assets/travel_images/santorini_panorama.jpg"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions examples/travel_app/lib/src/catalog/itinerary.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ final itinerary = CatalogItem(
"component": {
"Image": {
"url": {
"literalString": "assets/travel_images/beach.jpg"
"literalString": "assets/travel_images/rio_de_janeiro.jpg"
}
}
}
Expand All @@ -211,7 +211,7 @@ final itinerary = CatalogItem(
"component": {
"Image": {
"url": {
"literalString": "assets/travel_images/city.jpg"
"literalString": "assets/travel_images/maldives_islands.jpg"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_genui/lib/src/catalog/core_widgets/image.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ final image = CatalogItem(
"component": {
"Image": {
"url": {
"literalString": "https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png"
"literalString": "https://storage.googleapis.com/cms-storage-bucket/lockup_flutter_horizontal.c823e53b3a1a7b0d36a9.png"
}
}
}
Expand Down
12 changes: 5 additions & 7 deletions packages/flutter_genui/test/image_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ void main() {
home: Builder(
builder: (context) => Scaffold(
body: image.widgetBuilder(
CatalogItemContext(
data: {
'url': {
'literalString':
'https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png',
},
data: {
'url': {
'literalString':
'https://storage.googleapis.com/cms-storage-bucket/lockup_flutter_horizontal.c823e53b3a1a7b0d36a9.png',
},
id: 'test_image',
buildChild: (_, [_]) => const SizedBox(),
Expand All @@ -46,7 +44,7 @@ void main() {
expect(imageWidget.image, isA<NetworkImage>());
expect(
(imageWidget.image as NetworkImage).url,
'https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png',
'https://storage.googleapis.com/cms-storage-bucket/lockup_flutter_horizontal.c823e53b3a1a7b0d36a9.png',
);
});
});
Expand Down
Loading