Fix runtime errors in catalog_gallery example #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses two runtime exceptions in the catalog_gallery example. The refactoring to introduce _CatalogGalleryHome is a good solution for the ScaffoldMessenger issue. The fix for the JSON encoding error is also a good improvement. I have one suggestion to make the onSubmit handler more robust to prevent a potential runtime crash if a message does not contain any text parts.
5 tasks
- Fix ScaffoldMessenger error by moving UI code to _CatalogGalleryHome - Fix JSON encoding error by using messageText instead of jsonEncode(message.parts.last) - Resolves two runtime exceptions that prevented the example from running properly
MeandNi
force-pushed
the
fix/catalog-gallery-runtime-errors
branch
from
8b4a432 to
62961b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: Converting object to an encodable object failed: Instance of 'TextPart'
#0 _JsonStringifier.writeObject (dart:convert/json.dart:824:7)
json.dart:824
#1 _JsonStringStringifier.printOn (dart:convert/json.dart:1024:17)
json.dart:1024
#2 _JsonStringStringifier.stringify (dart:convert/json.dart:1005:5)
json.dart:1005
#3 JsonEncoder.convert (dart:convert/json.dart:353:30)
json.dart:353
#4 JsonCodec.encode (dart:convert/json.dart:238:45)
json.dart:238
#5 jsonEncode (dart:convert/json.dart:118:12)
json.dart:118
#6 _CatalogGalleryHome.build. (package:catalog_gallery/main.dart:57:28)
main.dart:57
#7 _RootZone.runUnaryGuarded (dart:async/zone.dart:1778:10)
zone.dart:1778
#8 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:381:11)
stream_impl.dart:381
#9 _DelayedData.perform (dart:async/stream_impl.dart:573:14)
stream_impl.dart:573
#10 _PendingEvents.handleNext (dart:async/stream_impl.dart:678:11)
stream_impl.dart:678
#11 _PendingEvents.schedule. (dart:async/stream_impl.dart:649:7)
stream_impl.dart:649
#12 _microtaskLo<…>