Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to get Fusion working: #4069

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Tweaks to get Fusion working: #4069

merged 2 commits into from
Dec 3, 2024

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Dec 3, 2024

  1. Don't ask for masked fields - our tests names have spaces and potentially other "regex escaped fields" - instead just get the whole document.
  2. Set the 'is_fusion' build property when re/scheduling presubmits

@jtmcdole
Tweaks to get Fusion working:
691d338 
1. Don't ask for masked fields - our tests names have spaces and
   potentially other "regex escaped fields" - instead just get the whole
   document.
2. Set the 'is_fusion' build property when re/scheduling presubmits
christopherfujino
christopherfujino approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 3, 2024
@auto-submit auto-submit bot merged commit c72521e into flutter:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtmcdole @christopherfujino