Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start package cocoon_server for shared server-side cocoon code #4056

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Nov 27, 2024

app_dart and auto_submit provide essentially the same service from two different entrypoints. Right now it's annoying to have to maintain copies of various services like Bigquery, API auth clients, datastore, firestore, graphql, REST API, etc. Every time we decide to move a piece of functionality between app_dart and auto_submit it involves unnecessary code copying and movement. For example, notice how #4043 had to duplicate deleteBranch in app_dart's bespoke github_service.dart.

This PR introduces a local package cocoon_server depended on by both app_dart and auto_submit. This PR only moves bigquery.dart and access_client_provider.dart. Future PRs can move more shared code into cocoon_server. Eventually, app_dart and auto_submit could become thin shells over cocoon_server that simply adapt it to their respective runtime environments.

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 4, 2024
@auto-submit auto-submit bot merged commit 2bf8bbc into flutter:main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants