Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload CocoaPods 1.16.2 in Ruby cipd package #4010

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 5, 2024

Follow up to #3992.
Pick up bug fixes from https://github.com/CocoaPods/CocoaPods/releases/tag/1.16.1 and https://github.com/CocoaPods/CocoaPods/releases/tag/1.16.2.

Particularly the revert of the issues explained in CocoaPods/Xcodeproj#987 (comment).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 5, 2024
@christopherfujino
Copy link
Contributor

We're expecting this to still fail postsubmit, because we haven't installed xcode cli tools, right?

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Nov 5, 2024

We're expecting this to still fail postsubmit, because we haven't installed xcode cli tools, right?

Yes exactly.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 5, 2024
@auto-submit auto-submit bot merged commit c68306f into flutter:main Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants