-
Notifications
You must be signed in to change notification settings - Fork 134
http_server: add headers method #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, maybe we need version info to know what version supports the method.
Could you add it?
Oh, sorry, maybe we need version info to know what version supports the method.
Could you add it?
Signed-off-by: Shizuo Fujita <[email protected]>
I added the supported version. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's merge after releasing v1.19.0.
Related to fluent/fluentd#4903