Skip to content

http_server: add headers method #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 1.0
Choose a base branch
from

Conversation

Watson1978
Copy link
Contributor

Related to fluent/fluentd#4903

daipom
daipom previously approved these changes Apr 11, 2025
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@daipom daipom self-requested a review April 11, 2025 09:17
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, maybe we need version info to know what version supports the method.
Could you add it?

@daipom daipom self-requested a review April 11, 2025 09:18
@daipom daipom dismissed their stale review April 11, 2025 09:18

Oh, sorry, maybe we need version info to know what version supports the method.
Could you add it?

@daipom daipom marked this pull request as draft April 11, 2025 09:19
Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978
Copy link
Contributor Author

I added the supported version. thanks

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's merge after releasing v1.19.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants