input_chunk: restrict appending chunks greater than size limit#9995
Open
braydonk wants to merge 2 commits intofluent:masterfrom
Open
input_chunk: restrict appending chunks greater than size limit#9995braydonk wants to merge 2 commits intofluent:masterfrom
braydonk wants to merge 2 commits intofluent:masterfrom
Conversation
Adds a configuration value that can be used instead of `FLB_INPUT_CHUNK_FS_MAX_SIZE` for the max size of an input chunk. Signed-off-by: braydonk <braydonk@google.com>
Perform a check during `input_log_append` that will verify that the passed buffer does not exceed the chunk max size. If that is the case, the chunk will be split into multiple sets of data that are as big as they can be before the chunk size limit to be appended separately. Signed-off-by: braydonk <braydonk@google.com>
braydonk
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
This was referenced Feb 24, 2025
braydonk
commented
Feb 24, 2025
| /* Send the events we have so far. */ | ||
| ret = flb_input_chunk_append_raw(ins, FLB_INPUT_LOGS, in_records, | ||
| tag, tag_len, | ||
| out_buf + in_buf_start, in_buf_size); |
Contributor
Author
There was a problem hiding this comment.
Egg on my face, I never realized that arithmetic on void pointers is illegal in compilers other than GCC; GCC handles void a special way, making sizeof(void) = 1. I'll need to think of another way to do this to allow for other compilers to work.
|
Would love to see some movement on this! |
Contributor
Author
|
I will likely not get time in the foreseeable future to finish this PR. Anyone is welcome to take it over the finish line. |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
Could this be resolved? |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt at restricting input chunk sizes by splitting up input buffers in
input_log_appendbased on the chunk max size. It also adds a companion configuration optionstorage.chunk_max_sizeto configure the max chunk size.Detailed information can be found in the companion gist I wrote, which contains explanations of this solution, the other solutions I tried that failed, and testing methodology. https://gist.github.com/braydonk/f32256488e989c4e807b0f9ba69bebbb
Issues: #9374, #1938
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.