Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: added multithreaded worker support for proxy plugins #3862

Closed
wants to merge 1 commit into from
Closed

proxy: added multithreaded worker support for proxy plugins #3862

wants to merge 1 commit into from

Conversation

gautampunhani
Copy link
Contributor

This applies the same code change brought in for making output plugins performant in v1.7.0 to the proxy plugins of Go.
Without this change if the go output plugin gets slow/unresponsive, other input plugins and output plugins also were getting stuck because of single-threaded nature of invocation.

This addresses issue fluent-bit-go#45


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
    Please note that, Valgrind with golang plugins show leaks without this change as well

Documentation

  • [N/A] Documentation required for this feature (Documentation will be same as any output plugin with workers)

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

This patch adds worker support to golang output plugins, without which if golang plugins were becoming unresponsive it was blocking other i/p and o/p plugins as well

Signed-off-by: Gautam Punhani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant