-
Notifications
You must be signed in to change notification settings - Fork 531
pipeline: outputs: stackdriver: general cleanup #1988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: outputs: stackdriver: general cleanup #1988
Conversation
Signed-off-by: Alexa Kreizinger <[email protected]>
Fluent Bit plans to support some [special fields in structured payloads](https://cloud.google.com/logging/docs/agent/configuration#special-fields). For more information, see the documentation about [special fields](https://github.com/fluent/fluent-bit-docs/blob/master/pipeline/outputs/stackdriver_special_fields.md#log-entry-fields). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ewwwwww. I know we're not rewriting things, but forward-looking statements are not a good thing to put in documentation. Just noting that, here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed 😔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left comments and suggestions, but I've added my approval based on those to keep this moving.
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: Alexa Kreizinger <[email protected]>
this PR is part of the effort to meet guidelines for style, clarity, and consistency.