Skip to content

Vale: Set Ordinal test to error, fix problems #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ The following tests are at a `error` level and will prevent merging:
in [Google Docs](https://support.google.com/docs/thread/217182974/can-i-turn-smart-quotes-off-in-a-google-doc?hl=en)
or [Microsoft Word](https://support.microsoft.com/en-us/office/smart-quotes-in-word-and-powerpoint-702fc92e-b723-4e3d-b2cc-71dedaf2f343)
to prevent this problem.
- [Ordinal](https://developers.google.com/style/numbers)
- [Repetition](https://github.com/errata-ai/vale/blob/v3/testdata/styles/Markup/Repetition.yml):
Checks for the same word used twice in succession.

Expand Down
23 changes: 12 additions & 11 deletions pipeline/filters/throttle.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,31 +15,33 @@ The plugin supports the following configuration parameters:

## Functional description

Lets imagine we have configured:
Using the following configuration:

```text
Rate 5
Window 5
Interval 1s
```

we received 1 message first second, 3 messages 2nd, and 5 3rd. As you can see, disregard that Window is actually 5, we use "slow" start to prevent overflooding during the startup.
You would received 1 message in the first second, 3 messages second, and 5 third.
Disregard that Window is actually 5, because the configuration uses `slow` start
to prevent flooding during the startup.

```text
+-------+-+-+-+
|1|3|5| | | | |
+-------+-+-+-+
| 3 | average = 3, and not 1.8 if you calculate 0 for last 2 panes.
+-------+-+-+-+
|1|3|5| | | | |
+-------+-+-+-+
| 3 | average = 3, and not 1.8 if you calculate 0 for last 2 panes.
+-----+
```

But as soon as we reached Window size \* Interval, we will have true sliding window with aggregation over complete window.

```text
+-------------+
|1|3|5|7|3|4| |
+-------------+
| 4.4 |
+-------------+
|1|3|5|7|3|4| |
+-------------+
| 4.4 |
----------+
```

Expand Down Expand Up @@ -135,4 +137,3 @@ $ bin/fluent-bit -i tail -p 'path=lines.txt' -F throttle -p 'rate=1' -m '*' -o s
```

The example above will pass 1000 messages per second in average over 300 seconds.

4 changes: 2 additions & 2 deletions pipeline/inputs/process-exporter-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description: >-
[Prometheus Node Exporter](https://github.com/prometheus/node_exporter) is a popular way to collect system level metrics from operating systems, such as CPU / Disk / Network / Process statistics.
Fluent Bit 2.2 onwards includes a process exporter plugin that builds off the Prometheus design to collect process level metrics without having to manage two separate processes or agents.

The Process Exporter Metrics plugin implements collecting of the various metrics available from [the 3rd party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter) and these will be expanded over time as needed.
The Process Exporter Metrics plugin implements collecting of the various metrics available from [the third party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter) and these will be expanded over time as needed.

**Important note:** All metrics including those collected with this plugin flow through a separate pipeline from logs and current filters do not operate on top of metrics.

Expand Down Expand Up @@ -103,6 +103,6 @@ docker run -ti -v /proc:/host/proc:ro \

## Enhancement Requests

Development prioritises a subset of the available collectors in the [the 3rd party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter), to request others please open a Github issue by using the following template:\
Development prioritises a subset of the available collectors in the [the third party implementation of Prometheus Process Exporter](https://github.com/ncabatoff/process-exporter), to request others please open a Github issue by using the following template:\
\
\- [in_process_exporter_metrics](https://github.com/fluent/fluent-bit/issues/new?assignees=\&labels=\&template=feature_request.md\&title=in_process_exporter_metrics:%20add%20ABC%20collector)
4 changes: 2 additions & 2 deletions vale-styles/FluentBit/Ordinal.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
extends: existence
message: "Spell out all ordinal numbers ('%s') in text."
link: 'https://developers.google.com/style/numbers'
level: suggestion
level: error
nonword: true
tokens:
- \d+(?:st|nd|rd|th)
- \d+(?:st|nd|rd|th)