Fix bug in 'unpack' for compressed archives with names not ending in '.archive' #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esn't end with '.archive'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the
unpackmethod of theArchiveDirectoryclass, when the compressed archive directory name doesn't end with the standard.archiveextension (e.g.example.archive.tmprather thanexample.archive).In these cases an additional empty directory is created in parallel with the expected unpacked directory, with a name generated by dropping the last 7 characters of the archive directory name (e.g. for
example.archive.tmpit would beexample.arc).By extension the bug also affected the
unpackcommand (which calls theunpackmethod directly).The fix prevents the spurious directory being created.