Linter Rule 2: File Path Boogaloo #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Before this is review-ready, we need to get #1487 in line with the current version of main so that this PR doesn't look insane |
EagleoutIce
approved these changes
May 20, 2025
EagleoutIce
added a commit
that referenced
this pull request
May 31, 2025
* feat: initial linter format (#1374) * feat: initial linter format ideas i dunno * refactor: linting output was a terrible name * refactor: add todo * refactor: add another todo ✨ * refactor: allow using un-built search in linter rules * refactor: type safety for createSearch and processSearchResult * refactor: todo cleanup * enrichment and mapper system (#1397) * test: basic test setup for the enrichments * refactor: a lot of type wrangling * feat: mappers but the types are broken * feat-fix: our enrichers and mappers test runs! the result is just wrong lol * feat: call target enrichment functionality * refactor: remove documentation enrichment for now * Linter R1: Deprecated Functions (#1456) * feat: basic R1 functionality and tests * feat-fix: r1 function overloads * Linter query (#1482) * feat: linter query * refactor: tiny comment fixes * refactor: address comment changes * refactor: clean up deprecated functions list * refactor: clean up false positives in function list * feat: allow the linter query to accept rule configs (#1538) * create search api queries from old query api queries (#1546) * wip: basic framework for the query-to-search api * wip: more generic name for the flatten function for queries * feat: searches from queries * feat: retain access to original queries when using fromQuery * feat-fix: fix up linter and origin queries * Linter Rule 2: File Path Boogaloo (#1588) * feat: link to last call enrichment * feat: guard against supplying empty args to LastCall * feat: basic R2 functionality * feat-fix: use Definitely certainty because we are confident people * feat-fix: fix up compile errors * feat: ignore reads that are preceded by writes to the same file * feat-fix: text retriever fails on empty files when not ignoring case * feat-fix: linter query should pass input * feat: handle unknown paths in R2 * feat: added a linting rule metadata feature * refactor: rename metadata to .meta * feat-fix: find files in subfolders using file path validity linterp * feat-fix: use extractSimpleCfg for search enrichers * feat: include search and process timing stats in linter metadata * feat-fix: use the simple cfg for R2 * refactor: small R2 cfg performance optimization * refactor: various small refactorings * doc: in-code documentation * doc: basic linter documentation * refactor: fix a build inconsistency * feat(linter): transition to dfg origin --------- Co-authored-by: Ell (Julian) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.