Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Switch from node-gm to sharp #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JeremyPlease
Copy link

In an attempt to speed up some cloud code functions that rely on parse-image, I switched node-gm to sharp.

Some initial, very unscientific benchmarking (ie. resizing 200 images in a loop), show a ~35% increase in speed.

@codecov-io
Copy link

Current coverage is 96.66% (diff: 95.08%)

Merging #14 into master will decrease coverage by 0.95%

@@             master        #14   diff @@
==========================================
  Files             1          1          
  Lines            84         90     +6   
  Methods          18         19     +1   
  Messages          0          0          
  Branches         22         27     +5   
==========================================
+ Hits             82         87     +5   
- Misses            2          3     +1   
  Partials          0          0          

Powered by Codecov. Last update c1afa61...d048514

@funkenstrahlen
Copy link

Did you have a look on memory usage? I just switched away from sharp to this repo because sharp did use too much memory.

@JeremyPlease
Copy link
Author

@funkenstrahlen I never did any actual benchmarking or look at memory usage. I'm using my sharp branch in production without any issues.

@funkenstrahlen
Copy link

funkenstrahlen commented May 22, 2017

I had quite big memory issues with sharp as soon I had to convert +50 images in a row. If your code does not have this problem, I like it. Just test for it please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants