This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Switch from node-gm to sharp #14
Open
JeremyPlease
wants to merge
9
commits into
flovilmart:master
Choose a base branch
from
JeremyPlease:sharp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.66% (diff: 95.08%)@@ master #14 diff @@
==========================================
Files 1 1
Lines 84 90 +6
Methods 18 19 +1
Messages 0 0
Branches 22 27 +5
==========================================
+ Hits 82 87 +5
- Misses 2 3 +1
Partials 0 0
|
Did you have a look on memory usage? I just switched away from sharp to this repo because sharp did use too much memory. |
@funkenstrahlen I never did any actual benchmarking or look at memory usage. I'm using my sharp branch in production without any issues. |
I had quite big memory issues with sharp as soon I had to convert +50 images in a row. If your code does not have this problem, I like it. Just test for it please. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to speed up some cloud code functions that rely on
parse-image
, I switchednode-gm
tosharp
.Some initial, very unscientific benchmarking (ie. resizing 200 images in a loop), show a ~35% increase in speed.