-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON::Pure fix strict mode #585
base: master
Are you sure you want to change the base?
Conversation
I also noticed the docs in json/lib/json/pure/generator.rb Line 222 in 4f876a8
And the alignment in json/lib/json/pure/generator.rb Line 143 in 4f876a8
|
I'd rather not bundle multiple unrelated fixes in the same PR. Makes merging more complicated. |
Ah sorry, it's OTOH I think fixing the description of |
db37392
to
937900c
Compare
937900c
to
3652866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Followup: #519
Fix: #584