Skip to content

Conversation

@plegall
Copy link
Contributor

@plegall plegall commented May 3, 2017

I'm not sure about PHPWG_VERSION_01 in local_head. I think it was only for 2.3, but with previous code (before my change) it applied to all versions but 2.4.

@plegall
Copy link
Contributor Author

plegall commented May 17, 2017

@flop25 I see that you liked better adding a 29x.pattern.php which is the exact same file since 24x.pattern.php

$ md5sum *x.pattern.php
32c1ed8862b233f197b80fc9345234e4  23x.pattern.php
4ddcee965034442285067f7e265a1461  24x.pattern.php
4ddcee965034442285067f7e265a1461  25x.pattern.php
4ddcee965034442285067f7e265a1461  26x.pattern.php
4ddcee965034442285067f7e265a1461  27x.pattern.php
4ddcee965034442285067f7e265a1461  28x.pattern.php
4ddcee965034442285067f7e265a1461  29x.pattern.php

In my opinion my pull-request is much better and sustainable but you decide ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant