Repository navigation
chore: add pytest-timeout and refresh uv.lock - #6
Merged
Merged
Conversation
|
hectorvent
force-pushed
the
chore/pytest-timeout
branch
from
October 6, 2026 22:31
1717466 to
b7f2578
Compare
hectorvent
force-pushed
the
chore/pytest-timeout
branch
from
October 7, 2026 01:53
b7f2578 to
4400644
Compare
The CI integration job runs pytest -m integration --timeout=120, but pytest-timeout was never a dependency, so pytest exited with "unrecognized arguments: --timeout=120" before collecting a test. The integration suite has not actually run in CI on any recent main build. uv.lock also pinned testcontainers 4.14.2, which mypy treats as untyped, so `uv sync --extra dev && uv run mypy floci` failed under strict mode while CI (pip, testcontainers 4.15.0) passed. The lock now resolves testcontainers 4.15.0 on Python 3.10 and later, matching CI. Lockfile changes: pytest-timeout 2.4.0 added, testcontainers 4.14.2 to 4.15.0 (Python 3.10+). Everything else is the newer uv lockfile revision (3 to 5) dropping redundant markers; no other version changes. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
hectorvent
force-pushed
the
chore/pytest-timeout
branch
from
October 7, 2026 01:57
4400644 to
ebfad96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pytest-timeout>=2.3to thedevextra.testcontainersinuv.lock(4.14.2 to 4.15.0 on Python 3.10+).Why
pytest -m integration -v --timeout=120, butpytest-timeoutwas never installed, so pytest stops withunrecognized arguments: --timeout=120before collecting anything (for example run 37538885916 on docs: standardize README and community files #5). The integration suite has not actually run in CI on recentmainbuilds. Keeping the flag is deliberate: a hung container start should fail the job instead of stalling until the runner timeout.uv sync --extra dev, thenuv run mypy floci) failed the type check: the lock pinnedtestcontainers 4.14.2, which mypy treats as untyped, soFlociContainer(DockerContainer)failed understrict = true. CI installs with pip, resolves4.15.0and passes, so CI and the uv environment disagreed. The lock now matches what CI resolves.Area
Dev dependencies and lockfile only; no library code changes, so
chore:(no release).uv.lockpackage changes:pytest-timeout 2.4.0added;testcontainers4.14.2 to 4.15.0 for Python 3.10+ (the Python 3.9 forks keep their pins). The rest of the diff is the neweruvwriting lockfile revision 5 (was 3), which drops redundant per-dependency markers.Tests
pytest -m integration -v --timeout=120collects and passes the integration tests (4 passed, 5 deselected) on Linux, Python 3.11, and in this PR's CI.uv run ruff check .,uv run mypy floci(no issues) and the unit tests (5 passed).[tool.mypy] python_version = "3.9"is unsupported. It does not fail the check; whether to raise that target while 3.9 is a supported runtime is left for a separate decision.Note: the "Lint & type-check" job will still fail here until #5 merges.
ruff format --checkfails onmainbecause ruff 0.16 formats README code blocks, which #5 fixes.Refs
Found while reviewing CI on #5.