Skip to content

fix og images on custom domains #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flo-bit merged 1 commit into from
Apr 21, 2026
Merged

fix og images on custom domains #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/lib/website/EditableWebsite.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import { AllCardDefinitions, CardDefinitionsByType } from '../cards';
import { tick, type Component } from 'svelte';
import type { CardDefinition, CreationModalComponentProps } from '../cards/types';
import { page } from '$app/state';
import { env } from '$env/dynamic/public';
import { setIsCoarse, setIsMobile, setSelectedCardId, setSelectCard } from './context';
import Context from './Context.svelte';
import Head from './Head.svelte';
Expand Down Expand Up @@ -54,12 +54,8 @@
const sectionsEditingEnabled = $derived(isSectionsEditingEnabled(data.did));

const ogImageUrl = $derived.by(() => {
const origin = page.url.origin;
const v = data.updatedAt ? `?v=${data.updatedAt}` : '';
if (page.data.customDomain) return `${origin}/og-new.png${v}`;
const handle = data.profile?.handle;
const actor = handle && handle !== 'handle.invalid' ? handle : data.did;
return `${origin}/${actor}/og-new.png${v}`;
return `${env.PUBLIC_DOMAIN}/${data.did}/og-new.png${v}`;
});

// Snapshot the original cards and sections so savePage can detect deletions.
Expand Down
6 changes: 1 addition & 5 deletions src/lib/website/Website.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,8 @@
setHandleContext(data.handle as Handle);

const ogImageUrl = $derived.by(() => {
const origin = page.url.origin;
const v = data.updatedAt ? `?v=${data.updatedAt}` : '';
if (page.data.customDomain) return `${origin}/og-new.png${v}`;
const handle = data.profile?.handle;
const actor = handle && handle !== 'handle.invalid' ? handle : data.did;
return `${origin}/${actor}/og-new.png${v}`;
return `${env.PUBLIC_DOMAIN}/${data.did}/og-new.png${v}`;
});

let container: HTMLDivElement | undefined = $state();
Expand Down
Loading