Skip to content

chore: update ruff -> 1.14.1 and update rules for python 3.10 #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: update ruff -> 1.14.1 and update rules for python 3.10 #2918

wants to merge 1 commit into from

Conversation

@yaugenst-flex
Copy link
Collaborator

@yaugenst-flex yaugenst-flex commented Oct 22, 2025

No description provided.

@yaugenst-flex yaugenst-flex force-pushed the FXC-3793-update-ruff-rules-to-python-3-10 branch from 1006566 to 35f522d Compare October 22, 2025 12:36
@yaugenst-flex yaugenst-flex marked this pull request as ready for review October 22, 2025 12:36
@greptile-apps
Copy link

greptile-apps bot commented Oct 22, 2025

Skipped: This PR changes more files than the configured file change limit: (100)

@yaugenst-flex yaugenst-flex force-pushed the FXC-3793-update-ruff-rules-to-python-3-10 branch 2 times, most recently from f6c8fae to 7973fe5 Compare October 23, 2025 08:23
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

  • tidy3d/components/autograd/boxes.py (100%)
  • tidy3d/components/autograd/derivative_utils.py (100%)
  • tidy3d/components/autograd/field_map.py (100%)
  • tidy3d/components/autograd/types.py (100%)
  • tidy3d/components/base.py (100%)
  • tidy3d/components/base_sim/simulation.py (100%)
  • tidy3d/components/bc_placement.py (100%)
  • tidy3d/components/beam.py (100%)
  • tidy3d/components/boundary.py (100%)
  • tidy3d/components/data/data_array.py (100%)
  • tidy3d/components/data/dataset.py (100%)
  • tidy3d/components/data/monitor_data.py (100%)
  • tidy3d/components/data/sim_data.py (100%)
  • tidy3d/components/data/unstructured/base.py (100%)
  • tidy3d/components/data/unstructured/triangular.py (100%)
  • tidy3d/components/data/utils.py (100%)
  • tidy3d/components/data/validators.py (100%)
  • tidy3d/components/dispersion_fitter.py (100%)
  • tidy3d/components/eme/data/monitor_data.py (100%)
  • tidy3d/components/eme/data/sim_data.py (100%)
  • tidy3d/components/eme/grid.py (100%)
  • tidy3d/components/eme/monitor.py (100%)
  • tidy3d/components/eme/simulation.py (100%)
  • tidy3d/components/eme/sweep.py (100%)
  • tidy3d/components/field_projection.py (100%)
  • tidy3d/components/frequency_extrapolation.py (100%)
  • tidy3d/components/geometry/base.py (83.3%): Missing lines 2782
  • tidy3d/components/geometry/mesh.py (100%)
  • tidy3d/components/geometry/polyslab.py (100%)
  • tidy3d/components/geometry/utils.py (100%)
  • tidy3d/components/grid/corner_finder.py (100%)
  • tidy3d/components/grid/grid.py (100%)
  • tidy3d/components/grid/grid_spec.py (100%)
  • tidy3d/components/grid/mesher.py (100%)
  • tidy3d/components/lumped_element.py (100%)
  • tidy3d/components/material/multi_physics.py (100%)
  • tidy3d/components/material/solver_types.py (100%)
  • tidy3d/components/material/tcad/charge.py (100%)
  • tidy3d/components/material/tcad/heat.py (100%)
  • tidy3d/components/material/types.py (100%)
  • tidy3d/components/medium.py (100%)
  • tidy3d/components/microwave/data/monitor_data.py (100%)
  • tidy3d/components/microwave/impedance_calculator.py (100%)
  • tidy3d/components/microwave/mode_spec.py (100%)
  • tidy3d/components/microwave/path_integrals/integrals/base.py (100%)
  • tidy3d/components/microwave/path_integrals/specs/current.py (100%)
  • tidy3d/components/microwave/path_integrals/specs/impedance.py (100%)
  • tidy3d/components/microwave/path_integrals/types.py (100%)
  • tidy3d/components/mode/data/sim_data.py (100%)
  • tidy3d/components/mode/mode_solver.py (100%)
  • tidy3d/components/mode/simulation.py (100%)
  • tidy3d/components/mode/solver.py (100%)
  • tidy3d/components/mode_spec.py (100%)
  • tidy3d/components/monitor.py (100%)
  • tidy3d/components/parameter_perturbation.py (100%)
  • tidy3d/components/scene.py (100%)
  • tidy3d/components/simulation.py (100%)
  • tidy3d/components/source/current.py (100%)
  • tidy3d/components/source/field.py (100%)
  • tidy3d/components/source/time.py (100%)
  • tidy3d/components/source/utils.py (100%)
  • tidy3d/components/spice/sources/ac.py (100%)
  • tidy3d/components/spice/sources/dc.py (100%)
  • tidy3d/components/spice/sources/types.py (100%)
  • tidy3d/components/spice/types.py (100%)
  • tidy3d/components/structure.py (100%)
  • tidy3d/components/subpixel_spec.py (100%)
  • tidy3d/components/tcad/boundary/heat.py (100%)
  • tidy3d/components/tcad/data/monitor_data/abstract.py (100%)
  • tidy3d/components/tcad/data/monitor_data/charge.py (100%)
  • tidy3d/components/tcad/data/monitor_data/heat.py (100%)
  • tidy3d/components/tcad/data/monitor_data/mesh.py (100%)
  • tidy3d/components/tcad/data/sim_data.py (100%)
  • tidy3d/components/tcad/data/types.py (100%)
  • tidy3d/components/tcad/doping.py (100%)
  • tidy3d/components/tcad/generation_recombination.py (100%)
  • tidy3d/components/tcad/grid.py (100%)
  • tidy3d/components/tcad/simulation/heat_charge.py (100%)
  • tidy3d/components/tcad/source/heat.py (100%)
  • tidy3d/components/tcad/types.py (100%)
  • tidy3d/components/time_modulation.py (100%)
  • tidy3d/components/transformation.py (100%)
  • tidy3d/components/types/base.py (100%)
  • tidy3d/components/types/mode_spec.py (100%)
  • tidy3d/components/types/monitor.py (100%)
  • tidy3d/components/types/monitor_data.py (100%)
  • tidy3d/components/types/simulation.py (100%)
  • tidy3d/components/types/workflow.py (100%)
  • tidy3d/components/validators.py (100%)
  • tidy3d/components/viz/visualization_spec.py (100%)
  • tidy3d/config/legacy.py (100%)
  • tidy3d/config/loader.py (66.7%): Missing lines 163
  • tidy3d/config/manager.py (100%)
  • tidy3d/config/registry.py (100%)
  • tidy3d/config/sections.py (100%)
  • tidy3d/exceptions.py (100%)
  • tidy3d/log.py (100%)
  • tidy3d/material_library/material_library.py (100%)
  • tidy3d/plugins/autograd/differential_operators.py (100%)
  • tidy3d/plugins/autograd/functions.py (100%)
  • tidy3d/plugins/autograd/invdes/filters.py (100%)
  • tidy3d/plugins/autograd/invdes/parametrizations.py (100%)
  • tidy3d/plugins/autograd/invdes/penalties.py (100%)
  • tidy3d/plugins/autograd/primitives/interpolate.py (100%)
  • tidy3d/plugins/autograd/utilities.py (100%)
  • tidy3d/plugins/design/design.py (100%)
  • tidy3d/plugins/design/method.py (100%)
  • tidy3d/plugins/design/parameter.py (100%)
  • tidy3d/plugins/design/result.py (100%)
  • tidy3d/plugins/dispersion/fit.py (100%)
  • tidy3d/plugins/dispersion/web.py (100%)
  • tidy3d/plugins/expressions/init.py (100%)
  • tidy3d/plugins/expressions/base.py (100%)
  • tidy3d/plugins/expressions/metrics.py (100%)
  • tidy3d/plugins/expressions/types.py (100%)
  • tidy3d/plugins/expressions/variables.py (100%)
  • tidy3d/plugins/invdes/design.py (100%)
  • tidy3d/plugins/invdes/initialization.py (100%)
  • tidy3d/plugins/invdes/optimizer.py (100%)
  • tidy3d/plugins/invdes/penalty.py (100%)
  • tidy3d/plugins/invdes/region.py (100%)
  • tidy3d/plugins/invdes/result.py (100%)
  • tidy3d/plugins/invdes/transformation.py (100%)
  • tidy3d/plugins/klayout/drc/results.py (100%)
  • tidy3d/plugins/klayout/util.py (100%)
  • tidy3d/plugins/microwave/array_factor.py (100%)
  • tidy3d/plugins/microwave/lobe_measurer.py (100%)
  • tidy3d/plugins/resonance/resonance.py (100%)
  • tidy3d/plugins/smatrix/analysis/terminal.py (100%)
  • tidy3d/plugins/smatrix/component_modelers/base.py (100%)
  • tidy3d/plugins/smatrix/component_modelers/modal.py (100%)
  • tidy3d/plugins/smatrix/component_modelers/terminal.py (100%)
  • tidy3d/plugins/smatrix/component_modelers/types.py (100%)
  • tidy3d/plugins/smatrix/data/terminal.py (100%)
  • tidy3d/plugins/smatrix/data/types.py (100%)
  • tidy3d/plugins/smatrix/ports/base_lumped.py (100%)
  • tidy3d/plugins/smatrix/ports/coaxial_lumped.py (100%)
  • tidy3d/plugins/smatrix/ports/rectangular_lumped.py (100%)
  • tidy3d/plugins/smatrix/ports/types.py (100%)
  • tidy3d/plugins/smatrix/ports/wave.py (100%)
  • tidy3d/plugins/waveguide/rectangular_dielectric.py (100%)
  • tidy3d/updater.py (100%)
  • tidy3d/web/api/asynchronous.py (100%)
  • tidy3d/web/api/autograd/autograd.py (100%)
  • tidy3d/web/api/autograd/utils.py (100%)
  • tidy3d/web/api/connect_util.py (100%)
  • tidy3d/web/api/container.py (100%)
  • tidy3d/web/api/material_fitter.py (100%)
  • tidy3d/web/api/material_libray.py (100%)
  • tidy3d/web/api/mode.py (100%)
  • tidy3d/web/api/run.py (100%)
  • tidy3d/web/api/tidy3d_stub.py (100%)
  • tidy3d/web/api/webapi.py (100%)
  • tidy3d/web/core/account.py (100%)
  • tidy3d/web/core/exceptions.py (100%)
  • tidy3d/web/core/s3utils.py (100%)
  • tidy3d/web/core/task_core.py (100%)
  • tidy3d/web/core/task_info.py (100%)

Summary

  • Total: 629 lines
  • Missing: 2 lines
  • Coverage: 99%

tidy3d/components/geometry/base.py

  2778         float
  2779             Surface gradient vjp value
  2780         """
  2781 
! 2782         _fld_H_normal, flds_H_perp = self.pop_axis(("Hx", "Hy", "Hz"), axis=axis_normal)
  2783         Hs_perp = tuple(H_der_map[key] for key in flds_H_perp)
  2784 
  2785         is_2d, zero_dimension, do_singularity_correction = self._check_singularity_correction_pec(
  2786             self.size, axis_normal

tidy3d/config/loader.py

  159         segments = tuple(segment.lower() for segment in rest.split("__") if segment)
  160         if not segments:
  161             continue
  162         if segments[0] == "auth":
! 163             segments = ("web", *segments[1:])
  164         _assign_path(overrides, segments, value)
  165     return overrides
  166

@yaugenst-flex yaugenst-flex force-pushed the FXC-3793-update-ruff-rules-to-python-3-10 branch from 7973fe5 to 24679c1 Compare October 27, 2025 12:09
@yaugenst-flex yaugenst-flex force-pushed the FXC-3793-update-ruff-rules-to-python-3-10 branch from 24679c1 to 804d3de Compare October 27, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daquinteroflex daquinteroflex Awaiting requested review from daquinteroflex daquinteroflex is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yaugenst-flex